Opened 3 years ago
Closed 3 years ago
#13081 closed enhancement (fixed)
Make $taxonomy optional in get_term_link()
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | low | Milestone: | 3.1 |
| Component: | Taxonomy | Version: | |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: |
Description
When get_term_link() receives an object as the first argument, it shouldn't require the second $taxonomy argument, since the $term object already has it.
Attachments (1)
Change History (7)
comment:2
filosofo
— 3 years ago
- Owner changed from filosofo to scribu
- Status changed from new to assigned
comment:4
in reply to:
↑ 1
scribu
— 3 years ago
- Keywords commit added
- Milestone changed from Awaiting Triage to 3.1
Replying to nacin:
if !is_object($term) we would need to then return WP_Error if we don't get a $taxonomy either.
We would get a WP_Error from get_term() or get_term_by() so it's taken care of.
Patch still applies clean.
comment:6
markjaquith
— 3 years ago
- Resolution set to fixed
- Status changed from assigned to closed
Note: See
TracTickets for help on using
tickets.
if !is_object($term) we would need to then return WP_Error if we don't get a $taxonomy either.