id,summary,reporter,owner,description,type,status,priority,milestone,component,version,severity,resolution,keywords,cc
13163,Incorrect POP3 error messages in wp-mail.php,solarissmoke,westi,"The current code in wp-mail.php is:

{{{
$pop3 = new POP3();
$count = 0;

if ( ! $pop3->connect(get_option('mailserver_url'), get_option('mailserver_port') ) ||
	! $pop3->user(get_option('mailserver_login')) ||
	( ! $count = $pop3->pass(get_option('mailserver_pass')) ) ) {
		$pop3->quit();
		wp_die( ( 0 === $count ) ? __('There doesn’t seem to be any new mail.') : esc_html($pop3->ERROR) );
}
}}}

Because of the multiple OR statements, if one of the first two fails (i.e., connect() or user() ) then the pass() function is never called and $count is never changed from the initial 0. Thus (0 === $count) always evaluates to true in these cases, giving an incorrect error message. e.g., if the connection failed, you still get ""there doesn't seem to be any new mail"" instead of the POP3 error.",defect (bug),closed,normal,3.0,Blog by Email,3.0,normal,fixed,has-patch,