Opened 3 years ago

Closed 3 years ago

#13182 closed defect (bug) (fixed)

submitting options-media.php in is_multisite() == true mode loses values

Reported by: tott Owned by: tott
Priority: high Milestone: 3.0
Component: Media Version: 3.0
Severity: blocker Keywords: media options, media, multisite
Cc:

Description

When you save the media options on a multisite installation
the values upload_path, uploads_use_yearmonth_folders and upload_url_path and maybe more are set to empty values causing file uploads done after this to be messed up.

Attachments (1)

13182.diff​ (1.8 KB) - added by ryan 3 years ago.

Download all attachments as: .zip

Change History (5)

comment:1   lloydbudd — 3 years ago

  • Milestone changed from Unassigned to 3.0
  • Owner set to tott
  • Priority changed from normal to high
  • Severity changed from normal to critical
  • Status changed from new to assigned
  • Version set to 3.0

Can't release without this debugged (understood) if not fixed. Updated P/sev.

comment:2   ryan — 3 years ago

  • Severity changed from critical to blocker

ryan — 3 years ago

comment:3   ryan — 3 years ago

Looks like this was already partially implemented. $uploads_options holds these values and only adds them to the registered options if !is_mutltisite(). Unfortunately, they were still hard-coded into the registered options array. Removing them from there should fix this. Patch untested.

comment:4   ryan — 3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14316]) Don't stomp upload options when saving media options for MS sites. fixes #13182

Note: See TracTickets for help on using tickets.