shared code in get_mu_plugins() and get_dropins()

[hakre]

Aka code buplication.

FYI closedir() is not necessary in PHP. It only consumes runtime and memory if you use it especially with the @ operator.

duplicate code went in [13233], related Ticket is #11861

closedir() was taken directly from get_plugins. If you split this into two patches, we can consider drying up the code for 3.0. Not really necessary though -- it's quite similar code across the three functions, but extracting out the duplicated code isn't less complicated because of the differences.

Replying to nacin:

closedir() was taken directly from get_plugins.

The note for closedir was just a sidenote - no need to focus on that, that was informative.

If you split this into two patches, we can consider drying up the code for 3.0. Not really necessary though -- it's quite similar code across the three functions, but extracting out the duplicated code isn't less complicated because of the differences.

Standard plugins are handling directories recursively, mu and dropins don't to that. To not be so invasive, this is for those two only. So I would first love to see this in before extending it over other places as well.