Nav Menus 3.0 Code Sprint

[ptahdunbar]

Working ticket for the nav menus 3.0 code sprint.

changes "text" to "label" for the custom links metabox. corrects the alignment for list-controls links

(In [14352]) Nav menu tweaks. Props ptahdunbar. see #13220

The UI changes are looking much better, I just have 1 concern over the amount of white space found on the right-hand side, it's like it's making room for another column or something? If you take a look at ​http://twitpic.com/1kgrlr then the bit in red shows you exactly, would it make sense to have that fill the space available?

In my opinion, yes I think it would!

toggle the "select all" link to check or uncheck links

Replying to markmcwilliams:

The UI changes are looking much better, I just have 1 concern over the amount of white space found on the right-hand side, it's like it's making room for another column or something? If you take a look at ​http://twitpic.com/1kgrlr then the bit in red shows you exactly, would it make sense to have that fill the space available?

In my opinion, yes I think it would!

Having the menu items as fixed width makes sense because it means that the input boxes aren't stretched out or look too short within the box (like they would be if the item box was full width). It probably also gives a little bit more distinction to the nested items as well.

remove dupe class attr (cannot find it referenced elsewhere either)

Nesting and not breaking out of the container upon expansion are the reasons behind the whitespace, as suggested above.

(In [14408]) Truncate really long menu names. props koopersmith, see #13220.

(In [14413]) Remove unused CSS. props koopersmith, see #13220

splits up the submission forms so they can be invoked individually.

same as previous patch, but based on r14434 not r14433

"Add Home Link" feature, doesn't work without js yet

i`m not really sure if it depends on one of these updates today but i thinke one of the javascript updates broke the editor (javascripts) and some more stuff in the dashboard.. (?)

sorry if i`m wrong - but everything (trunk) was working nice till one update (about js) today

Replying to LazyMe:

i`m not really sure if it depends on one of these updates today but i thinke one of the javascript updates broke the editor (javascripts) and some more stuff in the dashboard.. (?)

sorry if i`m wrong - but everything (trunk) was working nice till one update (about js) today

define ('CONCATENATE_SCRIPTS', false);

if false, it works again - if true it depends on the blog.. strange. (since today - trunk)

define(SCRIPT_DEBUG, true) loads unconcatenated scripts and also the development versions. We didn't bump the script loader every single commit yesterday, so you may need to bust your cache.

Replying to jane:

Nesting and not breaking out of the container upon expansion are the reasons behind the whitespace, as suggested above.

Fair enough! :)

revert accidental css removal in r14337

@LazyMe
Thanks, it's fixed in #9008

Replying to nacin:

define(SCRIPT_DEBUG, true) loads unconcatenated scripts and also the development versions. We didn't bump the script loader every single commit yesterday, so you may need to bust your cache.

i`m stupid - thanks for the information, nacin.

It actually was a bug of some sort, see #9008.

highlights the home link in nav menus

(In [14457]) Check custom links, including a home link, against the current URL to see if we should add current-menu-item. props ptahdunbar, fixes #13213, see #13220.

(In [14467]) Minor JS var declaration optimizations. props koopersmith, see #13220.

Missed a variable in js.warnings.begone.1.patch, was causing a bug in select all. Fixed above.

(In [14474]) Remove more trailing commas in nav menus JS. props koopersmith and ocean90, see #13220.

Markup Validation

(In [14475]) Adopt WP's general JS structure. Remove last of trailing commas. Remove dead code. props koopersmith, see #13220.

(In [14482]) Ensure valid HTML in the nav menu UI. props ocean90, see #13220.

(In [14520]) Allow menu items to be dropped on a parent item in addition to just being dragged to the right. props koopersmith, see #13220.

See #13311

Another thing: ​http://grab.by/4hLW If a post/page has no title we should add (no title) as menu label

(In [14531]) Some sortable improvements in the nav menu UI. props koopersmith, see #13220.