Opened 3 years ago

Closed 3 years ago

#13245 closed enhancement (fixed)

Add trailing slash to home_url() path

Reported by: zeo Owned by:
Priority: normal Milestone: 3.0
Component: Template Version: 3.0
Severity: normal Keywords: 2nd-opinion has-patch
Cc: zeo@…

Description

Add missing trailing slash in home_url() path and some clean up.

Attachments (1)

13245.patch​ (2.9 KB) - added by zeo 3 years ago.

Download all attachments as: .zip

Change History (6)

comment:1   zeo — 3 years ago

  • Keywords 2nd-opinion has-patch added
  • Owner 2nd-opinion has-patch deleted
  • Status changed from new to assigned

comment:2   nacin — 3 years ago

The change in default-widgets is invalid -- that's JS that we don't want escaped or filtered quite like that.

Also, get_search_query() in that case should actually be unescaped, then escaped, like: esc_url( home_url( '/?s=' . get_search_query( false ) ) ); (I think).

comment:3   sivel — 3 years ago

  • Keywords needs-refresh added; has-patch removed

zeo — 3 years ago

comment:4   zeo — 3 years ago

  • Keywords has-patch added; needs-refresh removed

Oops I think I previously send a wrong patch. Attached is the correct one according to title.

That default-widgets, feed-atom-comments, and author-template is for #9008. Sorry.

comment:5   nacin — 3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [14443]) Add trailing slash to some home_url() calls. props zeo, fixes #13245.

Note: See TracTickets for help on using tickets.