Opened 3 years ago
Closed 2 years ago
#13352 closed defect (bug) (wontfix)
get_children() displays drafts by default
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | General | Version: | |
| Severity: | normal | Keywords: | has-patch 2nd-opinion |
| Cc: | lew@… |
Description
Was working with get_children and noticed that it was displaying some draft pages. According to the current documentation (http://codex.wordpress.org/Function_Reference/get_children) the default is "any" for post status:
$argspost_status?
(string) Any value from the post_status column of the wp_posts table, such as publish, draft, or inherit; or the keyword any. Default: any
I believe it should act like get_posts --- the default should be "publish" for posts and "inherit" for attachments.
Attached is my diff with the fix...
basically I removed the $defaults setting of 'post_status' => 'any'... and I let get_posts handle the logic.
Attachments (1)
Change History (7)
- Keywords has_patch needs_testing added; has-patch get_children removed
- Keywords has-patch needs-testing added; has_patch needs_testing removed
- Keywords 2nd-opinion added; needs-testing removed
- Milestone changed from Awaiting Review to 3.1
Should either be committed or wontfixed. This sounds like it could break things.
Yeah, in my opinion, it would only negatively affect people/places that are trying to get draft children and are using the default 'any' status. Pragmatically, I can't imagine why anyone would want that as default behavior... but I'm only looking at it from my use cases.
get_children -- remove default post_status = any