Opened 3 years ago
Last modified 5 months ago
#13416 new defect (bug)
media for install.css missing (patch)
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Awaiting Review |
| Component: | Administration | Version: | 3.0 |
| Severity: | normal | Keywords: | has-patch ui-focus |
| Cc: | 24-7@… |
Description
In /core-root/wp-includes/general_template.php the function wp_admin_css is missing the @media definition. See patch.
Attachments (2)
Change History (10)
F J Kaiser
— 3 years ago
comment:1
F J Kaiser
— 3 years ago
- Cc 24-7@… added
comment:2
F J Kaiser
— 3 years ago
- Keywords has-patch added
comment:4
hakre
— 3 years ago
I like the idea, patch still applies clean.
If there can be made no decision whether or not to use that (no idea if the rest of WP uses that attribute) I suggest to close the ticket as wontfix.
comment:5
F J Kaiser
— 3 years ago
Just leave it open until there is a decision based on a discussion. No need for getting rid of this just to make the list shorter.
comment:6
SergeyBiryukov
— 10 months ago
- Component changed from General to UI
- Keywords css install media removed
DrewAPicture
— 5 months ago
comment:7
follow-up:
↓ 8
DrewAPicture
— 5 months ago
- Component changed from UI to Administration
- Keywords ui-focus added
- Milestone changed from Future Release to Awaiting Review
Refreshed the patch on current trunk. I'd vote to keep it screen in the patch if only because we can't guarantee all. OTOH, the script-loader uses all.
comment:8
in reply to:
↑ 7
F J Kaiser
— 5 months ago
Replying to DrewAPicture:
Refreshed the patch on current trunk.
Remind me next time to update an open tab before making a patch :P
Moving out of 3.0 for now. The media attribute isn't required, and if omitted, it defaults to 'all'. So setting it to 'screen' might affect some other views and devices.