WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 6 months ago

#13536 closed defect (bug) (fixed)

There are too few tickets on the 3.0 milestone

Reported by: matt Owned by: ryan
Priority: highest omg bbq Milestone: 3.0
Component: Validation Version: 3.0
Severity: blocker Keywords: has-patch has-unit-tests has-docs 2nd-opinion
Cc: Ken@…

Description

The 3.0 milestone is getting sparse, I'm afraid the remaining tickets might get lonely and start to pout.

Can we really be that close? :)

Attachments (5)

13536.diff​ (599 bytes) - added by johnonolan 3 years ago.
Fixes #13536
WP_NO_CATS.png​ (53.7 KB) - added by dancole 3 years ago.
I guess we need to start putting up some signs.
13536.2.diff​ (599 bytes) - added by wpmuguru 3 years ago.
fix spelling in 13536.diff
unit-tests.diff​ (537 bytes) - added by westi 3 years ago.
Unit tests for this and #13237
13536.3.diff​ (705 bytes) - added by nacin 3 years ago.

Download all attachments as: .zip

Change History (29)

comment:1 nacin — 3 years ago

  • Priority changed from lowest to highest omg bbq
  • Status changed from new to reviewing

comment:2 ryan — 3 years ago

Pouters get punted, where they will have lots of company. :-)

comment:3 westi — 3 years ago

This will take alot of fixing

comment:4 ryan — 3 years ago

There aren't alot of tickets here.

comment:5 markjaquith — 3 years ago

  • Summary changed from There's too few tickets on the 3.0 milestone to There are too few tickets on the 3.0 milestone

"Tickets" is plural, so using "there's" (a contraction of "there is") here results in a subject/verb disagreement.

comment:6 matt — 3 years ago

I don't agree with your subject/verb agreement!

comment:8 markjaquith — 3 years ago

We'll just have to subject/verb agree to subject/verb disagree.

comment:9 in reply to: ↑ 7 wmrom — 3 years ago

Replying to nacin:

Suggesting close as a duplicate of #13231 #13467 #13383 #13525 #13259 #13364 #13482 #12812 #13379 #13447 #13204 #12758 #13304 #13533 #13483 #13530 #10122 #13511 #13529 #11232 #13474 #13491 and #13479.

Don't forget that it's a duplicate of #13237 too.

comment:10 follow-up: masonjames — 3 years ago

I love that many trac tickets refer to this alot.

comment:11 wpmuguru — 3 years ago

Thanks, matt :)

comment:12 in reply to: ↑ 10 alot — 3 years ago

Replying to masonjames:

I love that many trac tickets refer to this alot.

Refer to who?

johnonolan — 3 years ago

Fixes #13536

comment:13 johnonolan — 3 years ago

  • Keywords has-patch added

dancole — 3 years ago

I guess we need to start putting up some signs.

comment:14 WraithKenny — 3 years ago

  • Cc Ken@… added

comment:15 follow-up: Denis-de-Bernardy — 3 years ago

  • Keywords commit added; close removed

Patch looks good. :-)

comment:16 in reply to: ↑ 15 GautamGupta — 3 years ago

Replying to dancole:

I guess we need to start putting up some signs.

Put dogs on the other side :P

comment:17 hakre — 3 years ago

  • Keywords needs-unit-tests added

Hope this ain't a blocker for this party :P

comment:18 GautamGupta — 3 years ago

  • Keywords needs-docs added; commit removed

A kitten comment isn't enough, you need to write why did you put that there! :P
Please add docs and re-submit the patch.

wpmuguru — 3 years ago

fix spelling in 13536.diff

westi — 3 years ago

Unit tests for this and #13237

comment:19 westi — 3 years ago

  • Keywords has-unit-tests added; needs-unit-tests removed

nacin — 3 years ago

comment:20 nacin — 3 years ago

  • Keywords has-docs 2nd-opinion added; needs-docs removed

comment:21 GautamGupta — 3 years ago

  • Keywords needs-codex added

Don't forget the codex!

comment:22 nacin — 3 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

[14996]

comment:23 johnonolan — 3 years ago

Best changeset EVAR! I lol'd alot

comment:24 mbijon — 6 months ago

  • Keywords needs-codex removed
Note: See TracTickets for help on using tickets.