Unused validation in wpmu_activate_signup

[filosofo]

wpmu_activate_signup calls wpmu_validate_user_signup without acting on its response.

Patch returns errors, if any are generated by wpmu_validate_user_signup. Otherwise, it uses the username and email as validated by wpmu_validate_user_signup.

The call to wpmu_validate_blog_signup() is the same way.

Introduced here:

​http://trac.mu.wordpress.org/changeset/1012

Looks like the validation is done in validate_user_signup() and validate_blog_signup() in wp-signup.php. Does wp_activate_signup() really need to run these again, or can it assume what is pulled from the DB is safe?

That patch doesn't work. When it's applied activation fails indicating that the username has already been reserved.

For now, I'm removing the validate calls for both users & sites. I'll leave teh ticket open for patches if someone wants to provide one.

(In [15186]) removed unused validation from activation process, see #13760

Let's call it done.