Opened 3 years ago
Last modified 3 years ago
#13867 new enhancement
New filter for comment RSS feed's title
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Future Release |
| Component: | Feeds | Version: | 3.0 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | shidouhikari |
Description
I'd like to be able to customize comments titles in RSS feed.
Currently it's hardcoded and has no way to be changed, so I added 2 new filters so that plugins can edit them.
I've tested and patch is working for me.
Attachments (1)
Change History (5)
shidouhikari — 3 years ago
- Keywords early removed
- Milestone changed from 3.1 to Future Release
These can already be filtered through gettext filters.
comment:2
shidouhikari — 3 years ago
- Cc shidouhikari added
As we talked in IRC, using gettext one would need to test for 'Comment on %1$s by %2$s' and 'By: %s'...
'By: %s' isn't something very exact for title filtering. A specific filter is simpler to handle and has no risk of other 'By: %s' somewhere else being messed. Also, if in a future version one of those texts are changed, anything relying on them would get broken.
With a specific filter, just let core do its work and then filter the result.
And sorry about the early, I thought it means patches in an early new milestone :p
- Milestone changed from Future Release to Awaiting Triage
- Type changed from feature request to enhancement
Per IRC.
Adds 2 filtters to allow plugins to edit comments titles in RSS feed