Ticket #1397 (closed defect (bug): fixed)

Opened 7 years ago

Last modified 5 years ago

comment_max_links discrepency

Reported by: chrisdolan Owned by: anonymous
Priority: normal Milestone:
Component: Administration Version: 1.5.1
Severity: minor Keywords: has-patch
Cc:

Description

In WP v1.5.1, the Options-Discussion page has an field labeled:

"Hold a comment in the queue if it contains more than N links."

However, it appears that the code enforces this as "more than equal to". This discrepency causes confusion.

Attachments

1397.diff Download (1.2 KB) - added by Nazgul 5 years ago.
1397_20.diff Download (1.2 KB) - added by Nazgul 5 years ago.

Change History

  • Patch set to No

The options->discussion page says "Hold a comment in the queue if it contains more than X links." but the code check in code had ">= get_settings('comment_max_links')" instead of just more-than.

(note - i sleepily entered the description on the patch as "less-than" not "more-than". Sorry.)

I got MarkJaquith to remove the patch, as he pointed out it is probably better to change the wording on the options-discussion.php page rather than change the code.

I was going to patch the options-discussion.php to say "Hold a comment in the queue if it contains %s or more links", though I do not know how that would affect language translations.

So I'll leave this executive decision to someone else.

Nazgul5 years ago

  • Keywords has-patch added
  • Milestone set to 2.1

Fixed the wording so it actually says what the code does.

Nazgul5 years ago

  • Milestone changed from 2.1 to 2.0.5

2.0.5 Candidate

  • Status changed from new to closed
  • Resolution set to fixed

(In [4303]) Clarify comment_max_links option text. Props chrisdolan and Nazgul. fixes 1397

I'll get this auto-close format right eventually!

fixes #1397

fixes #1397

[44304] same fix for branches/2.0 -> 2.0.5

  • Milestone 2.0.5 deleted

Milestone 2.0.5 deleted

Note: See TracTickets for help on using tickets.