Ticket #1397 (closed defect (bug): fixed)
comment_max_links discrepency
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Administration | Version: | 1.5.1 |
| Severity: | minor | Keywords: | has-patch |
| Cc: |
Description
In WP v1.5.1, the Options-Discussion page has an field labeled:
"Hold a comment in the queue if it contains more than N links."
However, it appears that the code enforces this as "more than equal to". This discrepency causes confusion.
Attachments
Change History
The options->discussion page says "Hold a comment in the queue if it contains more than X links." but the code check in code had ">= get_settings('comment_max_links')" instead of just more-than.
(note - i sleepily entered the description on the patch as "less-than" not "more-than". Sorry.)
I got MarkJaquith to remove the patch, as he pointed out it is probably better to change the wording on the options-discussion.php page rather than change the code.
I was going to patch the options-discussion.php to say "Hold a comment in the queue if it contains %s or more links", though I do not know how that would affect language translations.
So I'll leave this executive decision to someone else.
- Keywords has-patch added
- Milestone set to 2.1
Fixed the wording so it actually says what the code does.
comment:6
markjaquith — 5 years ago
- Status changed from new to closed
- Resolution set to fixed
comment:7
foolswisdom — 5 years ago
[44304] same fix for branches/2.0 -> 2.0.5

