get_terms() has 'search' and 'name__like'

[dd32]

Both do similar things:

	if ( !empty($name__like) )
		$where .= " AND t.name LIKE '{$name__like}%'";
...

	if ( !empty($search) ) {
		$search = like_escape($search);
		$where .= " AND (t.name LIKE '%$search%')";
	}

namelike should be removed in favour of search IMO, unless that functionality is intended, and in that case, namelike should get like_escape() applied

in addition to that, Terms are stored in the database htmlspecialchar'd by the looks of it (ie. '&'), The search should take that into consideration and apply the same filtering to the searching term.

I would prefer removing 'search' instead, as it's unclear what fields are actually being searched.

After thinking a bit more

• name__like should get escaped, and work as it currently does
• search should do both name AND slug, Not sure description is worth it?

Added diff that includes your suggestions, with search looking for name OR slug. No need to include description IMO.