Maintenance mode nag persists after successful upgrade

[mrmist]

A number of forum users are reporting that the maintenance nag

"An automated WordPress update has failed to complete" etc.. persists after failed auto-updates even if they then successfully perform manual updates.

Looks like something is leaving $upgrading set.

This would mean we're not removing the .maintenance file after a manual upgrade, which... we can't exactly detect.

No no, it means the update_core (site) transient didn't get reset as it should.

Woops, nevermind. You're absolutely correct.

Marking this as an enhancement. We should change the message to something that prompts to delete the .maintenance file after a successful manual upgrade.

On one hand, I would rather there just be a "Dismiss" option (which deletes the file) instead of forcing them to go into FTP and delete the file.

I suppose if they're updating manually, they're already logged in via FTP, in which case part of those instructions should be to remove .maintenance if it exists. We can add that to the Codex as a quick fix.

If removing .maintenance will sort it, then I can add that to codex docs etc.

I see I can't set milestones here any more, trac permissions have changed?

Replying to mrmist:

If removing .maintenance will sort it, then I can add that to codex docs etc.

It will indeed.

I see I can't set milestones here any more, trac permissions have changed?

​Yes.

Fair enough. I've altered the Codex manual update instructions to reference the .maintenance file.