WP3.0 XMLRPC wp.newCategory fails for existing category

[andrewpeacock]

Hi,
I'm comparing 2.9.2 and 3.0 with the same remote client calling WP's XMLRPC, as follows:

<?php
require("class.xmlrpc.php");
$client = new IXR_Client("URL");
$client->debug = true;
$content = Array();
$content["name"] = "1-800-PetMeds";
if (!$client->query('wp.newCategory', "", "USERNAME", "PASSWORD", $content)) {
	die('Something went wrong - '.$client->getErrorCode().' : '.$client->getErrorMessage());
} else {
	$categoryID = $client->getResponse();
}
?>

On 2.9.2:

• If the category name is not in use, the category is created and the new ID returned.
• If the category name is in use, the existing ID is returned.

On 3.0:

• If the category name is not in use, the category is created and the new ID returned.
• If the category name is in use, a generic XMLRPC is returne:

<?xml version="1.0"?>
<methodResponse>
<fault>
<value>
<struct>
<member>
<name>faultCode</name>
<value><int>500</int></value>
</member>
<member>
<name>faultString</name>
<value><string>Sorry, the new category failed.</string></value>
</member>
</struct>
</value>
</fault>
</methodResponse>

Due to changes to wp_insert_term(). Patch (untested) returns the ID of the existing term when issuing a term_exists WP_Error. newCategory passes that ID along when it sees term_exists.

(In [15425]) If category already exists, return its ID. Restores previous behavior. fixes #14067 for 3.1

(In [15426]) If category already exists, return its ID. Restores previous behavior. fixes #14067 for 3.0.1