Opened 3 years ago

Last modified 10 months ago

#14273 assigned enhancement

maybe_create_table cleanup

Reported by: dragoonis Owned by: pento
Priority: normal Milestone: Future Release
Component: Database Version: 3.0
Severity: normal Keywords: has-patch
Cc:

Description

Cleaned up maybe_create_table() - no more iterations.
Cheers. Dragoonis aka Dr4g(irc).

Attachments (3)

install-helper.php​ (6.1 KB) - added by dragoonis 3 years ago.
maybe_create_table.diff​ (968 bytes) - added by dragoonis 3 years ago.
Sanitisation of table name
maybe_create_table.2.diff​ (1.2 KB) - added by pento 10 months ago.

Download all attachments as: .zip

Change History (8)

dragoonis — 3 years ago

comment:1   dragoonis — 3 years ago

Ignore the .php attachment.

dragoonis — 3 years ago

Sanitisation of table name

comment:2   scribu — 3 years ago

  • Keywords has-patch added

comment:3   scribu — 3 years ago

You should use $wpdb->prepare() instead of $wpdb->escape()

comment:4   nacin — 3 years ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to Future Release

pento — 10 months ago

comment:5   pento — 10 months ago

  • Keywords needs-refresh removed
  • Owner set to pento
  • Status changed from new to assigned

New patch cleans up the code, updates to use prepare() instead of escape().

Note: See TracTickets for help on using tickets.