#14298 closed enhancement (fixed)
Twenty Ten: new description and stylesheet cleanup
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.0.1 |
| Component: | Themes | Version: | 3.0 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | lance@… |
Description
- Better description. Feel free to tweak or suggest improvements. :)
- CSS cleanup. Add comment flags to main sections, spacing and formatting fixes, remove extra line endings, and add missing semicolons. I did not change any values -- patch only has format and spacing changes.
Attachments (3)
Change History (17)
lancewillett
— 3 years ago
lancewillett
— 3 years ago
comment:1
lancewillett
— 3 years ago
- Cc lance@… added
- Keywords has-patch needs-testing dev-feedback added
comment:3
follow-up:
↓ 4
zeo
— 3 years ago
Glad that you raise this issue again. http://core.trac.wordpress.org/ticket/13881#comment:2
But there's 1 more thing. I'm not sure whether this is the current habit or trend, but why this:
selector {
...
}
selector-2 {
...
}
instead of:
selector {
...
}
selector-2 {
...
}
comment:4
in reply to:
↑ 3
;
follow-up:
↓ 12
lancewillett
— 3 years ago
Replying to zeo:
But there's 1 more thing. I'm not sure whether this is the current habit or trend, but why this:
There should be no extra lines between declaration blocks. I'm working on a CSS code standards doc for the Codex with all this information (will publish it soon).
comment:5
lancewillett
— 3 years ago
Replying to nacin:
Description looks good.
Attaching an improved, trimmed up version with help from iandstewart.
comment:7
in reply to:
↑ 6
lancewillett
— 3 years ago
Replying to nacin:
Matt suggested s/2010 default theme/2010 theme/
Works for me. Future-proof, also gives us motivation for the next default theme. :)
comment:10
nacin
— 3 years ago
comment:11
nacin
— 3 years ago
comment:12
in reply to:
↑ 4
zeo
— 3 years ago
Replying to lancewillett:
There should be no extra lines between declaration blocks. I'm working on a CSS code standards doc for the Codex with all this information (will publish it soon).
Still, no concrete reason. Please provide one (or more). For readability sake, please add new line after each block.
Did you realize if you're making this a standard, then all existing stylesheet in WP core, WP themes repo should be updated.
comment:13
scribu
— 3 years ago
- Milestone changed from Awaiting Review to 3.1
comment:14
nacin
— 3 years ago
- Milestone changed from 3.1 to 3.0.1
Description looks good. I read through the style.css cleanup and confirmed that the patch stuck to formatting.