Opened 3 years ago

Last modified 15 months ago

#14325 new enhancement

No possibillity to add a "Home"-link to the nav_menu when there are no Pages

Reported by: lundj Owned by:
Priority: normal Milestone: Future Release
Component: Menus Version: 3.0
Severity: normal Keywords: ux-feedback has-patch needs-testing dev-feedback ui-feedback
Cc: lundj, 24-7@…, sabreuse@…, xoodrew@…, chappellind@…

Description

If you want to add a "Home" link to the new nav_menu in Wordpress 3.0 you can't do so, if there is no Page created yet. If there is no Page, there is also no "View All"-Button in the Pages-Section to view the "Home"-Link.

In my opinion the "Home-Link" in the Pages-Section is very hidden anyway.

Attachments (5)

14325-patch1.diff (4.2 KB) - added by Master Jake 16 months ago.
14325-patch1.png (19.9 KB) - added by DrewAPicture 16 months ago.
Screenshot of 14325-patch1.diff
14325-patch1B.png (19.9 KB) - added by DrewAPicture 16 months ago.
Left float button suggestion based on 14325-patch1.diff
14325-patch2.diff (5.3 KB) - added by DrewAPicture 16 months ago.
First try and rearranging elements
14325-patch2.png (17.4 KB) - added by DrewAPicture 16 months ago.
Screenshot of 14325-patch2.diff

Download all attachments as: .zip

Change History (23)

  • Cc lundj added

Related support thread http://wordpress.org/support/topic/wp_nav_menu-home-menu-item-should-be-dynamic?replies=1 "Home link [should] use <?php bloginfo('url'); ?> "

  • Keywords needs-patch added
  • Type changed from enhancement to defect (bug)

Also setting this to defect, as the visibility of a home link shouldn't depend on their being a Page present.

I agree. Having the 'Home' link in the Pages box is just confusing.

  • Keywords ux-feedback added
  • Milestone changed from Awaiting Review to Future Release

There isn't really a better place for it, unfortunately.

  • Cc 24-7@… added
  • Milestone changed from Future Release to 3.4
  • Type changed from defect (bug) to enhancement

We should incorporate it into the menu name area. We tried it there originally for this reason but couldn't make it look good placement wise and we were running out of time. We should look again.

  • Cc sabreuse@… added
  • Cc xoodrew@… added
  • Cc chappellind@… added
  • Keywords has-patch needs-testing dev-feedback added; needs-patch removed

Screenshot of 14325-patch1.diff

Left float button suggestion based on 14325-patch1.diff

attachment:14325-patch1.diff isn't inserting the menu item for me.

Also, attached a screenshot of @MasterJake's attachment:14325-patch1.diff

From a workflow standpoint, my main issue with the location of the Add Home Link button in attachment:14325-patch1.png is that it's so far over on the right with the 'Save Menu' button. What about floating it left, something along the lines of attachment:14325-patch1B.png?

Last edited 16 months ago by DrewAPicture (previous) (diff)

comment:13 follow-up: ↓ 14   master jake16 months ago

Woah you have a HUGE resolution!! Anyways, as far as it not working, you do know you have to rename the .js file right? WordPress uses the minified one, but I submitted the patch on the dev version.

Last edited 16 months ago by master jake (previous) (diff)

comment:14 in reply to: ↑ 13 ; follow-up: ↓ 15   DrewAPicture16 months ago

Replying to master jake:

Woah you have a HUGE resolution!! Anyways, as far as it not working, you do know you have to rename the .js file right? WordPress uses the mimicked one, but I submitted the patch on the dev version.

Ahh yes, it has indeed been a long day. I played a bit with floating the 'Add Home Link' button left but I had a heckuva time getting the 'Delete Menu' link to stay in line.

comment:15 in reply to: ↑ 14   Master Jake16 months ago

Replying to DrewAPicture:

Replying to master jake:

Woah you have a HUGE resolution!! Anyways, as far as it not working, you do know you have to rename the .js file right? WordPress uses the mimicked one, but I submitted the patch on the dev version.

Ahh yes, it has indeed been a long day. I played a bit with floating the 'Add Home Link' button left but I had a heckuva time getting the 'Delete Menu' link to stay in line.

Hehe, been a long day for me as well. I suppose if the button is having issues we could just make it a regular link.

attachment:14325-patch2.diff Rearranges the 'Add Home Link' button to float left.

Last edited 16 months ago by DrewAPicture (previous) (diff)

First try and rearranging elements

Screenshot of 14325-patch2.diff

  • Keywords ui-feedback added

I'm having mixed feelings about this one. The placement looks fine, but having that button next to a link makes the button look kind of awkward and out of place. Maybe it really should be a regular blue link (maybe underlined like the delete action is).

Version 0, edited 16 months ago by Master Jake (next)
  • Milestone changed from 3.4 to Future Release

We ran out of time to hit this for 3.4. Since we are hitting freeze and this hasn't been touched, punting until next time around.

Note: See TracTickets for help on using tickets.