#14381 closed defect (bug) (fixed)
WordPress doesn't report the currently active theme
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.0.1 |
| Component: | General | Version: | 3.0 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | joseph@… |
Attachments (4)
Change History (14)
josephscott — 3 years ago
The whole naming convention in this function is a little sucky it seems.
I guess we should clear some of that up too.
$current_theme->active_stylesheet = get_option( 'stylesheet' );
Should probably add so we get parent and child theme
Does api.wordpress.org need any fields other than Name and Version. It seems we are sending a lot of useless data.
Also, current_theme is being filled with the previous update response and then stuck into the request. Seems current_theme when sent in the request should not have checked and response fields.
That cleans things up a bit. $current_theme is gone. Instead the current theme slug is assigned to the 'current_theme' key of the themes array. This gets rid of all of the local cache junk that was being sent to api under the current_theme key. The themes array is populated with only the Name and Version for each theme. That's all I see being used api side. The last cached update and the new update are in better named $last_update and $new_update variables.
It seems we need to send more than just version, name, and slug to help with disambiguation. Updated patch to blacklist certain fields and let the rest through.
josephscott — 3 years ago
comment:8
josephscott — 3 years ago
I don't think we need Description, Tags or Screenshot fields either.
- Resolution set to fixed
- Status changed from new to closed

Should it use 'stylesheet' instead of 'template'?