Opened 3 years ago

Closed 3 years ago

#14409 closed defect (bug) (fixed)

Grammar fix for theme update

Reported by: mrmist Owned by:
Priority: normal Milestone: 3.1
Component: General Version: 3.0
Severity: trivial Keywords: has-patch
Cc:

Description

A minor fix for the themes update process - themes' files is possessive so should have an apostrophe.

The patch assumes that the phrase is talking about multiple themes, which it seems to be.

Attachments (1)

update-core.patch​ (1.3 KB) - added by mrmist 3 years ago.
themes

Download all attachments as: .zip

Change History (4)

mrmist — 3 years ago

themes

comment:1   demetris — 3 years ago

If I were to change only one thing there, it would be the capital T, which makes no sense.

The apostrophe is required if the noun is possessive, as you said, but here the noun can also be interpreted as a modifier of the following noun, in which case it is correct as it is now.

comment:2   nacin — 3 years ago

  • Milestone changed from Awaiting Review to 3.1

Nice catch. We should change "the Themes files" to just "theme files".

comment:3   nacin — 3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16002]) Language cleanup. props mrmist, fixes #14409.

Note: See TracTickets for help on using tickets.