Ticket #1447 (closed defect (bug): fixed)

Opened 7 years ago

Last modified 5 years ago

Wrong page titles in added Admin Menus

Reported by: whoismanu Owned by: anonymous
Priority: normal Milestone:
Component: Administration Version: 1.5.2
Severity: normal Keywords: submenu menu admin wp-admin
Cc:

Description

There seems to be a problem with the page titles shown for menus/submenus that have been added via

add_submenu_page(parent, page_title, menu_title, access_level, file, [function]);

You can reconstruct this problem by installing the Example plugin from the wiki page:

 http://codex.wordpress.org/Adding_Administration_Menus#Example

If you install the plugin, a 'Test Options' submenu gets added to the 'Options' menu. If you click on 'Test Options' you will notice that the page title is 'Test Manage'. 'Test Manage' however is the page title of another submenu ('Test Manage') that has been added to the 'Manage' menu. The same holds for 'Test Toplevel', it also gets the page title from 'Test Manage'.

The problem seems to occur if you have several submenus that are added from the same plugin page. In this case the condition

else if (isset($plugin_page) && ($plugin_page == $submenu_array[2]))

in the 'get_admin_page_title()' function (in admin-functions.php) becomes true for the first submenu encountered and consequently all the other submenus will have the same page title.

As the same structure is also used in 'get_admin_page_parent()' you might have to check this function as well as.

Attachments

admin-titles.diff Download (1.3 KB) - added by skeltoac 6 years ago.

Change History

comment:1   matt6 years ago

  • Milestone set to 2.0

comment:2   ryan6 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [3367]) Title fixes for plugin menu pages. fixes #1447

comment:3   ryan6 years ago

  • Milestone changed from 2.0 to 2.0.1
  • Milestone 2.0.1 deleted

Milestone 2.0.1 deleted

Note: See TracTickets for help on using tickets.