Minor coding standard flaws?

[wojtek.szkutnik]

While browsing the WP code I found a lot of minor coding standard flaws, like wrong-side comparisons ( "if x !== false instead" of "if false !== x" etc). It's a very low-priority thing, but maybe we could correct these things for the sake of code beauty? I could submit a patch, but as there is dozens of these things, it could get outdated very soon...

I think a good strategy is to fix coding standards along the way, as you work on other things.

Replying to wojtek.szkutnik:

While browsing the WP code I found a lot of minor coding standard flaws, like wrong-side comparisons ( "if x !== false instead" of "if false !== x" etc).

The point of doing those "Yoda conditions" is to be part of a practice that catches mistakes at the point of code construction. After the code is written, their value is gone. So I wouldn't spend time addressing them aside from when they're code changed for other reasons, as sribu suggests.

Replying to filosofo:

Replying to wojtek.szkutnik:

While browsing the WP code I found a lot of minor coding standard flaws, like wrong-side comparisons ( "if x !== false instead" of "if false !== x" etc).

The point of doing those "Yoda conditions" is to be part of a practice that catches mistakes at the point of code construction. After the code is written, their value is gone. So I wouldn't spend time addressing them aside from when they're code changed for other reasons, as sribu suggests.

That's the conclusion I came to after opening the ticket. However, I disagree with "yoda conditions" being useless after the code is written. It makes code more readable and helps avoid more mistakes when any changes are needed, so correcting them further along the way might prove to be useful. This being said, I close the ticket ;)

s/they're/their/

I guess I was writing phonetically.

Don't get me wrong; I think Yoda conditions are great and advocate their use.