Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#14624 closed enhancement (fixed)

Rename 'caller_get_posts' to 'ignore_stickies'

Reported by: scribu Owned by: nacin
Priority: normal Milestone: 3.1
Component: Query Version:
Severity: normal Keywords: has-patch commit
Cc:

Description

The 'caller_get_posts' query flag should be renamed to 'ignore_stickies', since that's the only thing it's used for:

​http://codex.wordpress.org/Function_Reference/query_posts#Sticky_Post_Parameters

It's original purpose, to signal to WP_Query that get_posts() is the origin of the call, is not relevant anymore.

Attachments (1)

14624.diff​ (2.2 KB) - added by scribu 3 years ago.

Download all attachments as: .zip

Change History (7)

scribu — 3 years ago

comment:1   scribu — 3 years ago

  • Keywords has-patch commit added

comment:2 follow-up: ↓ 4   nacin — 3 years ago

  • Owner set to nacin
  • Status changed from new to accepted

+1. Just for completeness I would suggest ignore_sticky_posts.

comment:3   scribu — 3 years ago

Sure, as long as it has 'sticky' in there. :)

comment:4 in reply to: ↑ 2   markmcwilliams — 3 years ago

Replying to nacin:

+1. Just for completeness I would suggest ignore_sticky_posts.

Yeah, what he said! :) +100

comment:5   markjaquith — 3 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed
  • Version set to 3.0.1

(In [15589]) Rename caller_get_posts WP_Query flag to ignore_sticky_posts, because that is the only thing it does. fixes #14624. props scribu

comment:6   scribu — 3 years ago

  • Version 3.0.1 deleted
Note: See TracTickets for help on using tickets.