Opened 3 years ago

Last modified 11 months ago

#14657 assigned enhancement

Resync Boolean Type Case

Reported by: jacobsantos Owned by:
Priority: normal Milestone: Future Release
Component: General Version:
Severity: trivial Keywords: has-patch needs-refresh
Cc:

Description

TRUE to true and FALSE to false.

It seems patches weren't inline with the lowercase usage of the boolean type. Depends on programmer preference.

Attachments (1)

booleans_are_types.patch (42.2 KB) - added by jacobsantos 3 years ago.
Change case of booleans in files.

Download all attachments as: .zip

Change History (5)

Change case of booleans in files.

From what I remember, the use of the constants true and false should be lowercase. Patch looks good in that sense to me.

Well, to me they should be lowercase because of having to type them out a lot. The other reason is that language reserve words or keywords should always be lowercase to differentiate from other user defined terms.

The argument is whether or not the language type lowercase usage should be used verses the language implementation of them actually being constants, albeit case-insensitive constants.

The problem also is that if we switch over to using what is defined as constants, we'll have to use NULL instead of null as well.

  • Keywords needs-refresh added; tested removed
  • Milestone changed from Awaiting Review to Future Release

No way this patch still applies.

This patches a few external libraries. We shouldn't patch those, it becomes more difficult to merge in changes from upstream later on.

  • Status changed from new to assigned
Note: See TracTickets for help on using tickets.