Ticket #14727 (closed defect (bug): fixed)

Opened 21 months ago

Last modified 19 months ago

@license tag removal in xmlrpc.php

Reported by: hakre Owned by:
Priority: normal Milestone: 3.1
Component: General Version: 3.0.1
Severity: normal Keywords: has-patch
Cc:

Description

File /xmlrpc.php is labeled as being GPL v2 licensed. This is incompatible to our license (broken).

The file/code as been labeled as "GPL v2" in [7991] 25 May 2008. It was not tagged with any specific license before that date.

The file was added in [1348] by michelvaldrighi (a projects developer) 23 May 2004. The code in //xmlrpc.php extends code of Third-Party-Code in the IXR Package that just had been added in [1346] shortly before.

The adding of the PHPdoc @license tag in [7991] / #7037 was wrong because of this: if the code is by a project contributor, it must have been under the projects license (naming GPL v2 here would break that so it can not be GPL v2) or it is considered a derivate of the added code (because it extends from it), but then it must have been under the same license as the IXR class which is currently known not to be GPL v2.

I'm just for reverting leaving all other considerations aside.

Attachments

14727.patch Download (347 bytes) - added by hakre 21 months ago.

Change History

hakre21 months ago

Related: #14726, #14685

Tag: FIXIPO

Probably should. It might have been a test to see what it would look like in phpDocumentor without realizing that the implications of WordPress not actually being GPLv2 at the time.

Great feedback jacobsantos. That's very helpful.

  • Status changed from new to closed
  • Resolution set to fixed

(In [15557]) This file was mistakenly labeled as being GPLv2-only. fixes #14727

  • Status changed from closed to reopened
  • Resolution fixed deleted

props?

  • Status changed from reopened to closed
  • Resolution set to fixed

Re-closing.

Have a cookie, hakre.

  • Milestone changed from Awaiting Review to 3.1
Note: See TracTickets for help on using tickets.