Opened 3 years ago
Last modified 8 months ago
#14791 new enhancement
Twenty Ten Theme - Better Link Highlighting
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | WordPress.org |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | twentyten-a11y |
| Cc: |
Description
mainly changing the state of text decoration(underline/none). This aids users that tab through links on a page identify where they are.
Attachments (1)
Change History (14)
see also fixes for the gallery style #14792, may need to be applied at same time.
comment:4
follow-up:
↓ 7
iammattthomas — 3 years ago
I like the highlighting additions, but not sure why we're removing the underline from some elements on hover and focus. It seems inconsistent; why not let all focused, active, and hovered links have an underline to reinforce the "linkiness" of the links.
comment:5
follow-ups:
↓ 6
↓ 8
iammattthomas — 3 years ago
Also, -1 on losing the 10px border from gallery images. Adding a hover color can be a good idea, but we should use one that works with the larger border size -- it's a distinctive element in the design and I'd rather not lose it.
comment:6
in reply to:
↑ 5
iammattthomas — 3 years ago
Replying to iammattthomas:
Also, -1 on losing the 10px border from gallery images. Adding a hover color can be a good idea, but we should use one that works with the larger border size -- it's a distinctive element in the design and I'd rather not lose it.
(The other problem here is that to my color-blind eyes, a 1px border isn't enough for me to even see the highlight color without zooming in on the page.)
Replying to iammattthomas:
I like the highlighting additions, but not sure why we're removing the underline from some elements on hover and focus. It seems inconsistent; why not let all focused, active, and hovered links have an underline to reinforce the "linkiness" of the links.
I was attempting to flip the state, ie if they had underlines they got removed, and vice versa.
Replying to iammattthomas:
Also, -1 on losing the 10px border from gallery images. Adding a hover color can be a good idea, but we should use one that works with the larger border size -- it's a distinctive element in the design and I'd rather not lose it.
The 10px border - yeah to be honest I didn't think you'd like that change. It may need a separate color change, as the red was really ugly at that size.
I kept it to a 1px border on images to keep the change minimal, what width would you suggest for the standard (excluding special case like the gallery).
comment:9
in reply to:
↑ 7
iammattthomas — 3 years ago
Replying to elfin:
I was attempting to flip the state, ie if they had underlines they got removed, and vice versa.
Understood; I'd prefer to keep all links underlined on hover.
comment:10
in reply to:
↑ 8
iammattthomas — 3 years ago
Replying to elfin:
The 10px border - yeah to be honest I didn't think you'd like that change. It may need a separate color change, as the red was really ugly at that size.
I kept it to a 1px border on images to keep the change minimal, what width would you suggest for the standard (excluding special case like the gallery).
A fairly wide border, between 5-10px looks best in Twenty Ten. I'd not be opposed to a different color for images on hover since they're a special case -- but would let someone from the UI group chime in there since I'm color blind. :)
comment:11
nacin — 3 years ago
- Milestone changed from Awaiting Review to Future Release
comment:12
SergeyBiryukov — 9 months ago
- Component changed from Accessibility to Bundled Theme
comment:13
SergeyBiryukov — 8 months ago
- Milestone changed from Future Release to WordPress.org

ref previous ticket #14782