Database query for non-existent mods_themename option

[demetris]

I have noticed this in Twenty Ten and in a couple of other themes, but I imagine it must be the same for any theme for which the mods_themename option applies:

Unless you have visited one of the Menus, Background, etc. screens, and have modified something there, the mods_themename option is not added to the DB. As a result, WordPress does not find it in the autoloaded set and has to query the DB.

Let's try to add it when a theme gets activated.

My thought as I was filing the ticket was that this would be an one-liner fix if we had a hook for theme activation.

Open tickets for theme activation hook:

#7795

#13602

Can we try to resolve this by freeze (a few days from now)? Will also ping Ian Stewart and see if he can weigh in.

We had decided to avoid messing with switch_theme() in #15048, but to avoid the extra query, here's an attempt.

Looks good to me.

This is going to do an add_option on a front-page load.

We try and avoid those.

Moving out of 3.1 to Future Release

For later:

if ( is_admin() )
    add_option( "theme_mods_" . $stylesheet, (array) get_option( "mods_" . $theme ) );

(In [16958]) Add theme_mods option if is_admin. props MarkJaquith, fixes #14828.