HTTPS related issues in ms-blogs.php (with fix)

[mareck]

Two functions in ms-blogs.php have issues due to hard-coding "​http://" versus using the is_ssl() check. I have corrected them below. Just copy and paste these over the ones in your ms-blogs.php.

function get_blogaddress_by_id( $blog_id ) {

$protocol = is_ssl() ? '​https://' : '​http://';

$bloginfo = get_blog_details( (int) $blog_id, false ); only get bare details!
return esc_url( $protocol . $bloginfo->domain . $bloginfo->path );

}

function get_blogaddress_by_domain( $domain, $path ){

$protocol = is_ssl() ? '​https://' : '​http://';

if ( is_subdomain_install() ) {

$url = $protocol.$domain.$path;

} else {

if ( $domain != $_SERVERHTTP_HOST? ) {

$blogname = substr( $domain, 0, strpos( $domain, '.' ) );

$url = $protocol . substr( $domain, strpos( $domain, '.' ) + 1 ) . $path;

we're not installing the main blog
if ( $blogname != 'www.' )

$url .= $blogname . '/';

} else { main blog

$url = $protocol . $domain . $path;

}

}
return esc_url( $url );

}

Can you submit a patch?

http://core.trac.wordpress.org/#HowtoSubmitPatches

Oh well...

I think we would have to add a protocol argument to these functions.

Replying to ryan:

I think we would have to add a protocol argument to these functions.

Yeah.

Added patch for $ssl argument to both functions. Modified wp-admin/network/site-info.php to have a UI for this flag.

install_blog(), wpmu_welcome_notification(), and wpmu_activate_stylesheet() were left alone, and will autodetect SSL.

This looks good. Notes:

1. No need for the UI option. The changes in site-info.php can be entirely dropped I think.

2. Argument should be $scheme and should take 'https' and 'http' as valid values, default null at which point we use is_ssl. This allows us to add other protocols and it is also in line with functions in wp-includes/link-template.php.

3. General whitespace. Looks good mostly, but !isset($ssl) should be ! isset( $ssl ).

Going to run with this. Thanks for the initial patch.

(In [16987]) Add scheme arguments to get_blogaddress_by_domain and get_blogaddress_by_id. props adambackstrom for initial patch, fixes #14867.

(In [17005]) Revert [16987]. This pollutes home and siteurl during signup and blog creation. see #14867

Any news on this? This is turning out to be quite the maintenance headache for my particular install as we are running everything under ssl and have to go change the siteurl and home settings every time we setup a new blog.

You can automate that by hooking into the 'wpmu_new_blog' action.

Closed #18931 as a duplicate.