Make WordPress Core

Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#14935 closed defect (bug) (worksforme)

Taxonomy Permalinks Broken (Matt's Community Tags)

Reported by: ryan's profile ryan Owned by: scribu's profile scribu
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: Taxonomy Keywords:
Focuses: Cc:

Description

Taxonomy permalinks broke in trunk sometime since r15490. Example from Matt's blog:

http://ma.tt/person/stephane-daury/

Test with this plugin:

http://wordpress.org/extend/plugins/matts-community-tags/

Change History (14)

#1 @demetris
14 years ago

For me they stop working at r15613.

#2 @scribu
14 years ago

  • Owner set to scribu
  • Status changed from new to accepted

#3 @ryan
14 years ago

Here's $wp->query_vars for the /person/stephane-daury/ request.

array(3) { ["people"]=>  string(14) "stephane-daury" ["taxonomy"]=>  string(6) "people" ["term"]=>  string(14) "stephane-daury" } 

#4 @scribu
14 years ago

The problem is that it's supposed to look for attachments, so these extra args would be necessary:

'post_type' => 'attachment',
'post_status' => 'inherit'

I have no idea why it worked previously.

#5 @scribu
14 years ago

Part of the problem was fixed in [15650].

#6 @scribu
14 years ago

This is the SQL generated by the 3.0 branch:

SELECT SQL_CALC_FOUND_ROWS wp_posts . *
FROM wp_posts
WHERE 1=1
AND wp_posts.ID
IN ( 42447 )
AND wp_posts.post_type
IN (
'post', 'page', 'attachment'
)
AND (
wp_posts.post_status = 'publish'
OR wp_posts.post_author =1
AND wp_posts.post_status = 'private'
)
ORDER BY wp_posts.post_date DESC
LIMIT 0 , 10

and this is in trunk:

SELECT SQL_CALC_FOUND_ROWS wp_posts . *
FROM wp_posts
WHERE 1 =1
AND wp_posts.ID
IN ( 42447 )
AND wp_posts.post_type
IN (
'post', 'page', 'attachment'
)
AND (
wp_posts.post_status = 'publish'
OR wp_posts.post_status = 'private'
)
ORDER BY wp_posts.post_date DESC
LIMIT 0 , 10

neither of which work with the Matt's Community Tags plugin out of the box. This leads me to believe that Matt has some additional code running on his site, which doesn't work in trunk, for some reason.

#7 @scribu
14 years ago

  • Summary changed from Taxonomy Permalinks Broken to Taxonomy Permalinks Broken (Matt's Community Tags)

#8 @jane
13 years ago

  • Keywords needs-patch added

#9 @scribu
13 years ago

  • Keywords reporter-feedback added; needs-patch removed

#10 @markmcwilliams
13 years ago

It looks good at my end, whatever it was must have been fixed?

#11 @markjaquith
13 years ago

  • Resolution set to worksforme
  • Status changed from accepted to closed

#12 @nacin
13 years ago

  • Milestone 3.1 deleted

#13 @scribu
13 years ago

Probably fixed in #15982

#14 @markmcwilliams
13 years ago

  • Keywords reporter-feedback removed

We can remove the reporter-feedback keyword from here! :)

Note: See TracTickets for help on using tickets.