Ticket #1494 (closed defect (bug): fixed)

Opened 7 years ago

Last modified 5 years ago

Spurious notices about $HTTP_RAW_POST_DATA

Reported by: mgeisler Owned by: anonymous
Priority: normal Milestone:
Component: XML-RPC Version: 1.5.1.2
Severity: normal Keywords: has-patch
Cc:

Description

I'm seeing spurious notices from PHP about $HTTP_RAW_POST_DATA not being defined:

PHP Notice: Undefined variable: HTTP_RAW_POST_DATA in /home/mgeisler/mgeisler.net/html/xmlrpc.php on line 4

I guess one could wrap the line in a if(isset($HTTP_RAW_POST_DATA)) and at the same time move the call to logIO("I", $HTTP_RAW_POST_DATA) up in the same wrapping.

Or maybe it would be better to post-pone this processing to class-IXR.php since xmlrpc.php doesn't really use $HTTP_RAW_POST_DATA.

Attachments

1494.diff Download (343 bytes) - added by Nazgul 5 years ago.

Change History

Nazgul — 5 years ago

comment:1   Nazgul — 5 years ago

  • Keywords has-patch added
  • Milestone set to 2.1

The first reference to HTTP_RAW_POST_DATA is already guarded by an isset in trunk.

Patch attached which does the same for the second reference to HTTP_RAW_POST_DATA.

comment:2   Nazgul — 5 years ago

  • Milestone changed from 2.1 to 2.0.5

2.0.5 Candidate

comment:3   markjaquith — 5 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [4305]) avoid $HTTP_RAW_POST_DATA notices. props mgeisler and Nazgul. fixes #1494

comment:4   markjaquith — 5 years ago

(In [4306]) avoid $HTTP_RAW_POST_DATA notices. props mgeisler and Nazgul. fixes #1494

comment:5   anonymous — 5 years ago

  • Milestone 2.0.5 deleted

Milestone 2.0.5 deleted

Note: See TracTickets for help on using tickets.