Opened 3 years ago

Closed 9 months ago

#15361 closed defect (bug) (duplicate)

wp_start_object_cache() should be called within blog switching methods instead of wp_cache_init()

Reported by: prettyboymp Owned by:
Priority: normal Milestone:
Component: Cache Version:
Severity: normal Keywords:
Cc: mpretty@…, simon@…, willmot

Description

The switch_to_blog() and restore_current_blog() functions call wp_cache_init() directly, which causes the object cache instance to be recreated. These methods should instead be calling the wp_start_object_cache() method which correctly checks whether wp_cache_init() or wp_cache_reset() should be used.

Attachments (1)

16258.diff​ (682 bytes) - added by prettyboymp 3 years ago.

Download all attachments as: .zip

Change History (15)

prettyboymp — 3 years ago

comment:1   scribu — 3 years ago

Related: #14992

comment:2   scribu — 3 years ago

  • Component changed from General to Cache

comment:3   prettyboymp — 3 years ago

  • Cc mpretty@… added

comment:4   nacin — 3 years ago

  • Milestone changed from Awaiting Review to 3.1

comment:5   scribu — 3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16359]) Use wp_start_object_cache() in switch_to_blog(). Props prettyboymp. Fixes #15361

comment:6   scribu — 3 years ago

  • Summary changed from w_start_object_cache() should be called within blog switching methods instead of wp_cache_init() to wp_start_object_cache() should be called within blog switching methods instead of wp_cache_init()

comment:7   ryan — 3 years ago

We don't really need to re-add global and non-persistent groups or do those file and function exists checks. Maybe switch_to_blog() should directly call wp_cache_reset() if it exists otherwise do wp_cache_init().

comment:8   nacin — 3 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:9   Denis-de-Bernardy — 3 years ago

Suggesting we revert the changeset, for this reason:

http://core.trac.wordpress.org/ticket/14992#comment:7

comment:10   ryan — 2 years ago

(In [16597]) Revert [16359]. Deal with it in 3.2. see #15361

comment:11   ryan — 2 years ago

  • Milestone changed from 3.1 to Future Release

comment:12   simonwheatley — 2 years ago

  • Cc simon@… added

comment:13   willmot — 2 years ago

  • Cc willmot added

comment:14   nacin — 9 months ago

  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from reopened to closed

I think this is mostly handled now by #21434.

Note: See TracTickets for help on using tickets.