#15379 closed defect (bug) (duplicate)
is_email should be RFC complient
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | General | Version: | |
| Severity: | normal | Keywords: | needs-unit-test |
| Cc: |
Description
#blamenacin
Attachments (2)
Change History (11)
- Resolution set to duplicate
- Status changed from new to closed
Duplicate of #4616
There are alot of slashes in that patch. Can we use less? They are a natural resource after all.
Willing to commit this if you can produce 100% unit test coverage. I'll wait.
- Keywords needs-unit-test added
This patch has one main flaw and that is the lack of a capital P I think it needs-improvement
comment:7
coffee2code — 3 years ago
Hmm, looks like that one parenthesis is out of place...
If we wait until 3.2 with PHP 5.x, we can just do
filter_var( $email, FILTER_VALIDATE_EMAIL ) instead, right?
- Milestone Awaiting Review deleted
Replying to filosofo:
If we wait until 3.2 with PHP 5.x, we can just do
filter_var( $email, FILTER_VALIDATE_EMAIL ) instead, right?
Probably not. Those can be buggy. We could potentially leverage it internally but we need to watch out for vulnerabilities and what not across PHP versions.

I like this alot.