update_site_option can fail for values that cast to false
|Reported by:||duck_||Owned by:||duck_|
|Severity:||normal||Keywords:||3.3-early westi-likes has-patch commit|
Passing a value to update_site_option that casts to false (e.g. 0) doesn't work when the site option doesn't already exist because of:
if ( $value && !$wpdb->get_row( $wpdb->prepare( "SELECT meta_value FROM $wpdb->sitemeta WHERE meta_key = %s AND site_id = %d", $option, $wpdb->siteid ) ) ) return add_site_option( $option, $value );
update_option has no such restriction (the first part of the conditional).
Found when investigating #15496 as the compression test might call update_site_option('can_compress_scripts', 0);, so in some circumstances the compression test is loaded on every admin screen.
Change History (6)
- Keywords 3.2-early added
- Milestone changed from Awaiting Review to Future Release
- Keywords 3.3-early westi-likes commit added; 3.2-early removed
- Owner set to westi
- Status changed from new to assigned