WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#15507 closed defect (bug) (fixed)

Remove wp_admin_body_style()

Reported by: ocean90 Owned by:
Priority: normal Milestone: 3.1
Component: Administration Version: 3.1
Severity: normal Keywords: has-patch
Cc:

Description

I think we can remove the function. For admin we can use $admin_body_class and wp-admin.css and or themes can use body_class() .

Attachments (2)

14772.wp_admin_body_style.patch​ (2.1 KB) - added by ocean90 3 years ago.
admin_side_admin-bar_cleanup.patch​ (327 bytes) - added by WraithKenny 2 years ago.
Minor CSS fix for admin-bar

Download all attachments as: .zip

Change History (10)

ocean90 — 3 years ago

comment:1 ryan — 3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [16600]) Remove wp_admin_body_style(). Props ocean90. fixes #15507

WraithKenny — 2 years ago

Minor CSS fix for admin-bar

comment:2 WraithKenny — 2 years ago

Places the padding-top: 28px rule on the first appropriate element that isn't set to height: 100%; (which is #wphead).

In 3.1-RC3, you can see that the height of body.admin-bar is larger than 100% (easier to see on pages where the window is taller then the page content) which creates scroll-bars where none are needed.

(Might also provide a hint to Theme designers who look to wp-admin for css support on layouts that have css-positioned elements.)

Tested on Firefox 4.

comment:3 WraithKenny — 2 years ago

  • Resolution fixed deleted
  • Severity changed from normal to trivial
  • Status changed from closed to reopened

comment:4 WraithKenny — 2 years ago

  • Severity changed from trivial to normal

comment:5 SergeyBiryukov — 2 years ago

Patch tested, removes unnecessary scrollbars.

comment:6 ryan — 2 years ago

Looking okay in Chrome on Mac.

comment:7 ocean90 — 2 years ago

Opera and Firefox too.

comment:8 ryan — 2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [17368]) Admin bar CSS fix; removes unnecessary scrollbars. Props WraithKenny. fixes #15507

Note: See TracTickets for help on using tickets.