WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 16 months ago

#15520 new enhancement

Break date/time into a separate column in Comments views

Reported by: markel Owned by:
Priority: normal Milestone: Future Release
Component: Comments Version:
Severity: normal Keywords: needs-refresh
Cc: rmarkel@…, scribu, justin.shreve@…, dkikizas@…, r_a_m_i@…

Description

Now that column sorting is in, it makes sense to break the date and time a comment was made into a separate column in the Comments view so they can be sorted chronologically.

Currently, the time is part of the content column, which can be confusing as if someone sorts by that column it becomes an alphabetical sort.

Attachments (2)

commentcolumn.diff (4.5 KB) - added by jshreve 3 years ago.
Breaks out the submitted on text to its own sortable column
commentcolumn.png (41.8 KB) - added by jshreve 3 years ago.
Screenshot of date column for comments

Download all attachments as: .zip

Change History (16)

comment:1 markel3 years ago

  • Cc rmarkel@… added

comment:2 scribu3 years ago

  • Cc scribu added

jshreve3 years ago

Breaks out the submitted on text to its own sortable column

comment:3 jshreve3 years ago

  • Cc justin.shreve@… added

Made a quick patch that breaks out the "submitted on" text to its own sortable column. I debated creating a view link or keeping the date link clicakble but ended up keeping the date clickable. Also updated the inline help docs.

comment:4 scribu3 years ago

  • Keywords has-patch added

comment:5 nacin3 years ago

  • Keywords ux-feedback 2nd-opinion added
  • Milestone changed from Awaiting Review to 3.1

comment:6 follow-up: JohnONolan3 years ago

Screenshot please

jshreve3 years ago

Screenshot of date column for comments

comment:7 in reply to: ↑ 6 jshreve3 years ago

Replying to JohnONolan:

Screenshot please

Screenshot attached. As I mentioned we could also add a view link if we don't want the date linked still. Let me know and I can do another patch.

comment:8 follow-up: JohnONolan3 years ago

I like it in principle but think it might be too big of a UI change for this stage in the 3.1 cycle - translations and RTL need to be considered in particular.

This is an enhancement, not a bug, so I would suggest punting to 3.2

comment:9 scribu3 years ago

  • Keywords 3.2-early added
  • Milestone changed from 3.1 to Future Release

Agreed.

comment:10 demetris2 years ago

  • Cc dkikizas@… added

comment:11 in reply to: ↑ 8 ramiy22 months ago

  • Cc r_a_m_i@… added

comment:12 chexee19 months ago

  • Keywords needs-refresh added; 2nd-opinion 3.2-early removed

I think this is a good idea in principle as well. Would still like to see this in a Future Release.

The patch needs a bit of a refresh (fails at a few hunks for me. It adds the new column, but does not make it sortable).

comment:13 jane16 months ago

  • Keywords has-patch ux-feedback removed

Adding column fine by me.

comment:14 ramiy16 months ago

Can you break it into two lines:

current format "{date} at {time}"

new format "{date} <br /> {time}"

Note: See TracTickets for help on using tickets.