Opened 2 years ago

Last modified 9 days ago

#15576 new defect (bug)

Proper l10n of items per page in the screen options

Reported by: SergeyBiryukov Owned by:
Priority: normal Milestone: 3.6
Component: I18N Version: 3.1
Severity: normal Keywords: has-patch commit
Cc: SergeyBiryukov, nashwan.doaqan@…

Description (last modified by SergeyBiryukov)

Sites, Users, Comments, Media items and Plugins have their own translation context on the screen options tab, e.g. “sites per page (screen options)”.

To use the right grammatical case, Posts, Pages, Categories and Tags should have that context too.

Attachments (7)

15576.patch (2.4 KB) - added by SergeyBiryukov 2 years ago.
15576.2.patch (2.3 KB) - added by SergeyBiryukov 22 months ago.
15576.3.patch (4.0 KB) - added by SergeyBiryukov 19 months ago.
15576.4.patch (1.1 KB) - added by SergeyBiryukov 10 months ago.
15576.5.patch (1.1 KB) - added by SergeyBiryukov 10 months ago.
15576.6.patch (6.3 KB) - added by SergeyBiryukov 10 months ago.
15576.7.patch (6.2 KB) - added by DrewAPicture 2 weeks ago.
Refresh.

Download all attachments as: .zip

Change History (24)

comment:1   zeo2 years ago

Related #13673

comment:2   dd322 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Keywords 3.2-early has-patch added; needs-patch removed
  • Keywords 3.3-early added; 3.2-early removed

Refreshed for 3.3.

  • Milestone changed from Future Release to 3.3

Also, for proper translation all of these strings should support single and plural forms.

That part won't be implemented, according to nacin's comment on #13673.

The context, however, is still needed, so this is what the patch does.

comment:7 follow-up: ↓ 9   nacin19 months ago

  • Keywords 3.3-early removed
  • Milestone changed from 3.3 to Awaiting Review

15576.2.patch isn't very backwards compatible. per_page should be implemented like menu_name was -- if it isn't set, it goes forward with the existing "name" argument, rather than defaulting to "Posts"/"Pages".

  • Milestone changed from Awaiting Review to Future Release

comment:9 in reply to: ↑ 7   SergeyBiryukov19 months ago

Replying to nacin:

per_page should be implemented like menu_name was -- if it isn't set, it goes forward with the existing "name" argument, rather than defaulting to "Posts"/"Pages".

Thanks, done in 15576.3.patch.

  • Milestone changed from Future Release to 3.5

As an alternative, we could replace "Posts"/"Pages" with "items" string (15576.4.patch), which we already have in options-reading.php:
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/options-reading.php#L111

The use case is essentially the same, so the context might not be needed. 15576.5.patch adds it just in case (and uses the uppercased word for consistency with other screens).

With 15576.6.patch, we could remove 9 strings by making the same change on the other screens (for consistency as well).

  • Milestone changed from 3.5 to Future Release

Moving to "items" across the board is a decent idea. We can talk about it in 3.6.

  • Description modified (diff)

To summarize, "20 Записи" (20 Posts) isn't a valid expession in Russian.

It should be "20 записей", but it's currently impossible to use the proper translation due to the lack of context. I imagine Czech and other languages with declensions have the same problem here.

Introducing a new label just for screen options seems like an overkill, hence the "Items" suggestion.

Version 0, edited 7 months ago by SergeyBiryukov (next)
  • Milestone changed from Future Release to 3.6

Refresh.

15576.7.patch refreshes .6

Standardizing to 'Items' was a nice idea, great to remove some strings.

  • Keywords commit added
  • Cc nashwan.doaqan@… added
Note: See TracTickets for help on using tickets.