Opened 3 years ago
Last modified 4 weeks ago
#15576 new defect (bug)
Proper l10n of items per page in the screen options
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | I18N | Version: | 3.1 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | SergeyBiryukov, nashwan.doaqan@…, pavelevap |
Description (last modified by SergeyBiryukov)
Sites, Users, Comments, Media items and Plugins have their own translation context on the screen options tab, e.g. “sites per page (screen options)”.
To use the right grammatical case, Posts, Pages, Categories and Tags should have that context too.
Attachments (7)
Change History (28)
comment:2
dd32
— 2 years ago
- Keywords needs-patch added
- Milestone changed from Awaiting Review to Future Release
SergeyBiryukov
— 2 years ago
comment:3
SergeyBiryukov
— 2 years ago
- Keywords 3.2-early has-patch added; needs-patch removed
SergeyBiryukov
— 2 years ago
comment:4
SergeyBiryukov
— 2 years ago
- Keywords 3.3-early added; 3.2-early removed
Refreshed for 3.3.
comment:5
SergeyBiryukov
— 2 years ago
- Milestone changed from Future Release to 3.3
comment:6
in reply to:
↑ description
SergeyBiryukov
— 2 years ago
Also, for proper translation all of these strings should support single and plural forms.
That part won't be implemented, according to nacin's comment on #13673.
The context, however, is still needed, so this is what the patch does.
comment:7
follow-up:
↓ 9
nacin
— 20 months ago
- Keywords 3.3-early removed
- Milestone changed from 3.3 to Awaiting Review
15576.2.patch isn't very backwards compatible. per_page should be implemented like menu_name was -- if it isn't set, it goes forward with the existing "name" argument, rather than defaulting to "Posts"/"Pages".
SergeyBiryukov
— 20 months ago
comment:9
in reply to:
↑ 7
SergeyBiryukov
— 20 months ago
Replying to nacin:
per_page should be implemented like menu_name was -- if it isn't set, it goes forward with the existing "name" argument, rather than defaulting to "Posts"/"Pages".
Thanks, done in 15576.3.patch.
comment:10
SergeyBiryukov
— 12 months ago
- Milestone changed from Future Release to 3.5
SergeyBiryukov
— 11 months ago
SergeyBiryukov
— 11 months ago
SergeyBiryukov
— 11 months ago
comment:11
SergeyBiryukov
— 11 months ago
As an alternative, we could replace "Posts"/"Pages" with "items" string (15576.4.patch), which we already have in options-reading.php:
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/options-reading.php#L111
The use case is essentially the same, so the context might not be needed. 15576.5.patch adds it just in case (and uses the uppercased word for consistency with other screens).
With 15576.6.patch, we could remove 9 strings by making the same change on the other screens (for consistency as well).
comment:12
nacin
— 8 months ago
- Milestone changed from 3.5 to Future Release
Moving to "items" across the board is a decent idea. We can talk about it in 3.6.
comment:13
SergeyBiryukov
— 8 months ago
- Description modified (diff)
To summarize, "20 Записи" (20 Posts) isn't a valid expression in Russian.
It should be "20 записей", but it's currently impossible to use the proper translation due to the lack of context. I imagine Czech (according to pavelevap's comments on #13673) and other languages with declensions have the same problem here.
Introducing a new post type label just for screen options seems like an overkill, hence the "Items" suggestion.
comment:14
SergeyBiryukov
— 6 months ago
- Milestone changed from Future Release to 3.6
comment:15
DrewAPicture
— 7 weeks ago
15576.7.patch refreshes .6
Standardizing to 'Items' was a nice idea, great to remove some strings.
comment:16
SergeyBiryukov
— 6 weeks ago
- Keywords commit added
comment:17
alex-ye
— 6 weeks ago
- Cc nashwan.doaqan@… added
comment:18
follow-up:
↓ 20
ryan
— 4 weeks ago
I'd like translators to weigh in on whether they can work with having one string and context for all of these. Perhaps there are some langs without a convenient generic term like Items that covers all of these cases.
comment:19
SergeyBiryukov
— 4 weeks ago
- Cc pavelevap added
comment:20
in reply to:
↑ 18
SergeyBiryukov
— 4 weeks ago
Replying to ryan:
Perhaps there are some langs without a convenient generic term like Items that covers all of these cases.
If 15576.7.patch is too drastic, we could go with 15576.5.patch to just fix the lack of context for Posts/Pages/Categories/Tags.
15576.7.patch, however, seems more consistent, since the use case in all the instances is the same.
comment:21
pavelevap
— 4 weeks ago
I also really like the idea of one generic term, but:
1) There are some different plural forms, for example in Czech there are "4 položky" and "5 položek". There is no problem for default 20 items, but I am not sure about other languages...
2) It would be very helpfull for translators to manipulate with order, something like "% Items", so we could do for example "Number of Items: %". This is without problems in most languages, because we can use some internal localization "hacks".
And what about to change the string "Items" to "Number of Items:" or "Number of Items per page:" and move it before number selection? It would be more explanatory, there is enough space, etc. And also much better for translators, because there are not problems with different plurals.
Related #13673