WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 4 weeks ago

#15576 new defect (bug)

Proper l10n of items per page in the screen options — at Version 13

Reported by: SergeyBiryukov Owned by:
Priority: normal Milestone: 3.6
Component: I18N Version: 3.1
Severity: normal Keywords: has-patch commit
Cc: SergeyBiryukov, nashwan.doaqan@…, pavelevap

Description (last modified by SergeyBiryukov)

Sites, Users, Comments, Media items and Plugins have their own translation context on the screen options tab, e.g. “sites per page (screen options)”.

To use the right grammatical case, Posts, Pages, Categories and Tags should have that context too.

Change History (19)

comment:1 zeo3 years ago

Related #13673

comment:2 dd322 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

SergeyBiryukov2 years ago

comment:3 SergeyBiryukov2 years ago

  • Keywords 3.2-early has-patch added; needs-patch removed

SergeyBiryukov2 years ago

comment:4 SergeyBiryukov2 years ago

  • Keywords 3.3-early added; 3.2-early removed

Refreshed for 3.3.

comment:5 SergeyBiryukov2 years ago

  • Milestone changed from Future Release to 3.3

comment:6 in reply to: ↑ description SergeyBiryukov2 years ago

Also, for proper translation all of these strings should support single and plural forms.

That part won't be implemented, according to nacin's comment on #13673.

The context, however, is still needed, so this is what the patch does.

comment:7 follow-up: nacin20 months ago

  • Keywords 3.3-early removed
  • Milestone changed from 3.3 to Awaiting Review

15576.2.patch isn't very backwards compatible. per_page should be implemented like menu_name was -- if it isn't set, it goes forward with the existing "name" argument, rather than defaulting to "Posts"/"Pages".

comment:8 nacin20 months ago

  • Milestone changed from Awaiting Review to Future Release

SergeyBiryukov20 months ago

comment:9 in reply to: ↑ 7 SergeyBiryukov20 months ago

Replying to nacin:

per_page should be implemented like menu_name was -- if it isn't set, it goes forward with the existing "name" argument, rather than defaulting to "Posts"/"Pages".

Thanks, done in 15576.3.patch.

comment:10 SergeyBiryukov12 months ago

  • Milestone changed from Future Release to 3.5

SergeyBiryukov11 months ago

SergeyBiryukov11 months ago

SergeyBiryukov11 months ago

comment:11 SergeyBiryukov11 months ago

As an alternative, we could replace "Posts"/"Pages" with "items" string (15576.4.patch), which we already have in options-reading.php:
http://core.trac.wordpress.org/browser/tags/3.4.1/wp-admin/options-reading.php#L111

The use case is essentially the same, so the context might not be needed. 15576.5.patch adds it just in case (and uses the uppercased word for consistency with other screens).

With 15576.6.patch, we could remove 9 strings by making the same change on the other screens (for consistency as well).

comment:12 nacin8 months ago

  • Milestone changed from 3.5 to Future Release

Moving to "items" across the board is a decent idea. We can talk about it in 3.6.

comment:13 SergeyBiryukov8 months ago

  • Description modified (diff)

To summarize, "20 Записи" (20 Posts) isn't a valid expression in Russian.

It should be "20 записей", but it's currently impossible to use the proper translation due to the lack of context. I imagine Czech (according to pavelevap's comments on #13673) and other languages with declensions have the same problem here.

Introducing a new post type label just for screen options seems like an overkill, hence the "Items" suggestion.

Last edited 6 months ago by SergeyBiryukov (previous) (diff)
Note: See TracTickets for help on using tickets.