Opened 2 years ago
Closed 3 months ago
#15585 closed defect (bug) (fixed)
"LGPL License" should just be "LGPL"
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | lowest | Milestone: | 3.6 |
| Component: | General | Version: | 3.1 |
| Severity: | trivial | Keywords: | 3.2-early has-patch |
| Cc: |
Description (last modified by lloydbudd)
The GNU Lesser General Public License License?
$ ack -l "LGPL License" wp-admin/includes/class-ftp-pure.php wp-admin/includes/class-ftp-sockets.php wp-admin/includes/class-ftp.php wp-includes/js/tinymce/plugins/wpdialogs/editor_plugin.dev.js wp-includes/js/tinymce/plugins/wpdialogs/js/popup.dev.js wp-includes/js/tinymce/themes/advanced/js/charmap.js wp-includes/js/tinymce/utils/editable_selects.js wp-includes/js/tinymce/utils/form_utils.js wp-includes/js/tinymce/utils/mctabs.js wp-includes/js/tinymce/utils/validate.js
Attachments (2)
Change History (11)
comment:2
jacobsantos — 2 years ago
- Keywords 3.2-early added
- Milestone changed from Awaiting Review to Future Release
jakub.tyrcha — 23 months ago
comment:5
jakub.tyrcha — 23 months ago
PemFTP is not maintained at all, last commits date to 2008. The patch improves the wording in the FTP class files and the editor plugin for TinyMCE, which, I think, is maintained by WP?
comment:6
SergeyBiryukov — 22 months ago
- Keywords has-patch added
wonderboymusic — 4 months ago
comment:7
wonderboymusic — 4 months ago
- Milestone changed from Future Release to 3.6
Bringing back from the basement of 3.2-early - refreshed patch. FTP files are DocBlock'd by WordPress, as are the WP TinyMCE plugins, updated only those so they aren't clobbered by upstream updates.
comment:8
aaronholbrook — 4 months ago
Tested on trunk, looks good.
comment:9
markjaquith — 3 months ago
- Owner set to markjaquith
- Resolution set to fixed
- Status changed from new to closed
In 23425:
Note: See
TracTickets for help on using
tickets.
The TinyMCE files should not be modified by WordPress. This needs to be sent upstream because they will simply be overridden when TinyMCE is upgraded.
The Class FTP files are also third-party files, but I'm not sure if they are maintained and where the original files are. It would be better to send the patch upstream as well, but might suffice to simply fix it in WordPress.