Opened 2 years ago

Last modified 4 months ago

#15588 new enhancement

GoogleSpell.php preg_replace eval removed

Reported by: underground-stockholm Owned by:
Priority: normal Milestone: Future Release
Component: TinyMCE Version: 3.0.1
Severity: normal Keywords: has-patch upstream 3.2-early needs-refresh
Cc: nacin, westi, azaozz

Description

Hello,

I have found and fixed one more of the preg_replace /e eval constructs, that aren't allowed in WordPress according to the coding standards.

-- Frank | ​Underground Stockholm

Attachments (1)

googlespell.preg-eval-remove.diff​ (1005 bytes) - added by underground-stockholm 2 years ago.

Download all attachments as: .zip

Change History (5)

underground-stockholm — 2 years ago

comment:1   jacobsantos — 2 years ago

  • Type changed from defect (bug) to enhancement

This needs to be sent upstream to TinyMCE.

comment:2   westi — 2 years ago

  • Cc nacin westi added
  • Component changed from General to TinyMCE
  • Keywords upstream 3.2-early added
  • Milestone changed from Awaiting Review to Future Release

comment:3   ocean90 — 2 years ago

  • Cc azaozz added

comment:4   wonderboymusic — 4 months ago

  • Keywords needs-refresh added; needs-testing removed

Is this file even used? It also has mb_substr() - Multibyte String is a ​non-default extension in PHP, even now. GoogleSpell is named in a config here:

wp-includes/js/tinymce/plugins/spellchecker/config.php


Note: See TracTickets for help on using tickets.