Ticket #1564 (closed defect (bug): fixed)

Opened 7 years ago

Last modified 5 years ago

More and NextPage buttons missing in WYSI editor (patch)

Reported by: ringmaster Owned by: markjaquith
Priority: normal Milestone:
Component: Administration Version: 1.6
Severity: normal Keywords: editor more nextpage bg|needs-patch
Cc:

Description

In the new WYSI editor, there is no button for the more or nextpage comment tags that are used to separate pages within a post.

The attached files are a plugin for TinyMCE that adds these buttons to the toolbar. The comments are displayed graphically in the editor, but are stored as html comments upon output or when editing the html directly. The user can move the More and Nextpage placements by simply dragging them.

See  this image for an example of the display.

The "wordpress" directory in the archive goes into the tinymce/plugins directory. The single diff will patch the plugin features into the admin-header.php.

Localization of this TinyMCE plugin is incomplete.

Attachments

more_nextpage.zip Download (6.1 KB) - added by ringmaster 7 years ago.
Described patch and TinyMCE plugin
editor_plugin_src.js Download (7.4 KB) - added by JasonV 6 years ago.
Modified editor_plugin_src.js, 'name' changed to 'class'

Change History

Described patch and TinyMCE plugin

  • Keywords bg|has-patch bg|commit added
  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned
  • Milestone set to 1.6

comment:2   matt6 years ago

  • Status changed from assigned to closed
  • Resolution set to fixed
  • Status changed from closed to reopened
  • Resolution fixed deleted

"The comments are displayed graphically in the editor, but are stored as html comments upon output or when editing the html directly."

This does not seem to function correctly, because the image tags for the graphic display remain in the HTML and are NOT replaced by the WP HTML comments.

Ok, this seems to have fixed it: lines 163 and 173 in wp-includes/js/tinymce/plugins/wordpress/editor_plugin_src.js need to be changed from checking attribsname? to attribsclass?... or at least that did it for me. I'll try to put a patch together, but it might be quicker of somebody else did it, cause I haven't made a patch in a LONG time...

  • Keywords bg|needs-patch added; bg|has-patch bg|commit removed

JasonV6 years ago

Modified editor_plugin_src.js, 'name' changed to 'class'

comment:6   matt6 years ago

  • Status changed from reopened to closed
  • Resolution set to fixed

Already fixed.

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.