Blogger Importer notices

[joostdevalk]

I ran the Blogger Importer today on a blog with WP_DEBUG on and encountered too many notices, so I fixed them. Patch coming

Patch

Hi Joost,
I've got a working version of the importer based on Otto's OAuth fork. I also spotted the notices about unassigned variables.

I'm trying to understand part of your patch, I've changed get_user_options function to use get_users as follows.

function get_user_options($current) {
global $importer_users;
if ( ! isset( $importer_users ) )
        $importer_users = (array) get_users();  //Function: get_users_of_blog() Deprecated in version 3.1. Use get_users() instead.

        $options = '';

	foreach ( $importer_users as $user ) {
		$sel = ( $user->ID == $current ) ? " selected='selected'" : '';
		$options .= "<option value='$user->ID'$sel>$user->display_name</option>";
	}
	return $options;
}

You've also change $user->ID to $user->data->ID, is that still relavent now that the function has been swapped out?

With all the changes in 0.5, this patch should no longer be relevant. However, if there's any continuing notice issues, feel free to make a new ticket about it.