Opened 2 years ago
Last modified 2 years ago
#15795 closed enhancement
Press This should support post formats — at Version 12
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.1 |
| Component: | Press This | Version: | 3.1 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: |
Description (last modified by jane)
If Press This automatically used the default post status in v1 of post formats, it would have been fine, so I'm putting the priority back to normal.
Change History (19)
All for it. Even at the time I triaged it, it was a bit late for 3.1 though.
- Keywords needs-patch added; has-patch removed
Patch is missing some important bits that we see in post.php, such as theme support checks.
- Priority changed from normal to highest omg bbq
Per IRC discussion, let's go with a select box as a compromise for 3.1. Otherwise press this can't actually support this in terms of space.
I'm still not sure the POST handler logic is complete.
- Keywords has-patch added; needs-patch removed
with missing post/save logic
- Owner set to greuben
- Status changed from new to assigned
Looks good. Will review it tomorrow and give it a good tire kicking.
Assigning an owner so we can keep track of who is iterating the final tickets.
Will ask Jane if she can agree to these changes: http://cl.ly/350l0S1O3L0M1P1F2U0W.
For reference, here's the 3.0 version: http://cl.ly/1Q0u2B2g0C2H1E2y1F0a. (Of note, the publish box could not be moved or collapsed. Removing the redundant title is not the end of the world.)
comment:11
nacin — 2 years ago
Patch updated against default post formats in #15882.
Just needs final review.
comment:12
jane — 2 years ago
- Description modified (diff)
- Priority changed from highest omg bbq to normal
If Press This automatically used the default post status in v1 of post formats, it would have been fine, so I'm putting the priority back to normal.

I don't mean to rub it in, but: #14650 :)