Ticket #15799 (closed defect (bug): fixed)

Opened 18 months ago

Last modified 18 months ago

Deactivated Sites on MultiSite give 500 header

Reported by: Madtownlems Owned by:
Priority: normal Milestone: 3.1
Component: Multisite Version:
Severity: normal Keywords: has-patch commit
Cc:

Description

On a MultiSite network, users and admins can deactivate sites. When a non-logged in user tries to view the site, they get this message: This user has elected to delete their account and the content is no longer available.

However, the server's response is 500 (Internal Server Error)

I'm not 100% sure what it SHOULD respond (possibly 404?) but 500 seems quite wrong.

Attachments

15799.diff Download (1.1 KB) - added by nacin 18 months ago.
15799.2.diff Download (2.0 KB) - added by nacin 18 months ago.

Change History

comment:1   PeteMall — 18 months ago

What about 410?

nacin — 18 months ago

comment:2   nacin — 18 months ago

  • Milestone changed from Awaiting Review to 3.1

Patch sends 410 through wp_die().

I think we can also kill the WP_I18N. We moved ms_site_check() to the end of wp-settings.php, so we should have the network-wide locale at our disposal now.

nacin — 18 months ago

comment:3   nacin — 18 months ago

  • Keywords has-patch added

Second patch kills WP_I18N and removes some braces.

comment:4   PeteMall — 18 months ago

  • Keywords commit added

Patch does the trick... HTTP/1.1 410 Gone is returned for archived, spam or deleted sites.

comment:5   PeteMall — 18 months ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [16906]) Ensure correct HTTP status code is returned. Props nacin, fixes #15799

Note: See TracTickets for help on using tickets.