Opened 2 years ago

Last modified 2 weeks ago

#15801 assigned defect (bug)

Network Admin: Deactivated / Deleted inconsistency

Reported by: kawauso Owned by: PeteMall
Priority: normal Milestone: 3.6
Component: Text Changes Version: 3.1
Severity: normal Keywords: has-patch
Cc: ryan_b, aren@…, knut@…

Description

Under the Sites screen, there are distinct inline links for Deactivate and Delete. However, when a site is deactivated, it is referred to as deleted in:

  • Sites screen inline status
  • Edit Site screen attributes section
  • Error page for non-admins visiting the site

Attachments (1)

deactivated.diff​ (629 bytes) - added by wonderboymusic 7 months ago.

Download all attachments as: .zip

Change History (15)

comment:1   kawauso — 2 years ago

  • Severity changed from minor to normal

Leaving severity alone

comment:2   nacin — 2 years ago

  • Component changed from UI to Network Admin
  • Milestone changed from Awaiting Review to 3.1

comment:3   PeteMall — 2 years ago

  • Owner set to PeteMall
  • Status changed from new to assigned

comment:4   ryan_b — 2 years ago

  • Cc ryan_b added

comment:5   ryan_b — 2 years ago

From what I can tell, the delete link removes the site from the db, deactivate leaves it in the db and sets a flag called "deleted", so my question is if the flag is called deleted is the status being listed as "Deleted" the desired effect?

comment:6   ryan_b — 2 years ago

  • Keywords dev-feedback added

comment:7   ryan — 2 years ago

  • Milestone changed from 3.1 to Future Release

comment:8   scribu — 2 years ago

Related: #17164

comment:9   novasource — 22 months ago

  • Cc aren@… added

wonderboymusic — 7 months ago

comment:10   wonderboymusic — 7 months ago

  • Keywords has-patch added; dev-feedback removed
  • Milestone changed from Future Release to 3.5

Deactivated is the status for the Delete flag, Delete is an action that removes the site. Patched.

comment:11   nacin — 6 months ago

  • Milestone changed from 3.5 to Future Release

There's a lot of inconsistency here. Moving out of 3.5 for further review.

comment:12   knutsp — 6 months ago

  • Cc knut@… added

comment:13   wonderboymusic — 5 months ago

  • Milestone changed from Future Release to 3.6

comment:14   DrewAPicture — 2 weeks ago

  • Component changed from Network Admin to Text Changes

deactivated.diff​ looks good to me. It's a shame the flag is called 'deleted' but I'd assume changing it isn't an option.

Note: See TracTickets for help on using tickets.