Changes between Initial Version and Version 1 of Ticket #15856

Timestamp:
12/17/10 07:45:36 (2 years ago)
Author:
nacin
Comment:

show_admin_bar() has apparently been crippled.

You should be able to call show_admin_bar( false ) before the admin bar is initiated, and it should kill the admin bar.

We should either eliminate this function, or fix it. I vote to fix it, otherwise putting this simple logic into preview_theme() doesn't work: 

if ( isset( $_GET['TB_iframe'] ) )
    show_admin_bar( false );

And the call to show_admin_bar() in iframe_header() is useless.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #15856

    • Property Type changed from enhancement to defect (bug)
    • Property Summary changed from Admin bar shouldn't show in theme preview iframe to show_admin_bar(false) doesn't work

  • Ticket #15856 – Description

    initial v1  
    1 It takes up space and looks weird. People are trying to preview a theme, and the admin bar is an unnecessary constant. 
     1show_admin_bar(false) doesn't work. See the first comment for more. 
     2 
     3---- 
     4 
     5My initial report: 
     6'''Admin bar shouldn't show in theme preview iframe''' 
     7>It takes up space and looks weird. People are trying to preview a theme, and the admin bar is an unnecessary constant. 
     8 
     9This should also be fixed.