Problems with comment editing / replying / approving / trashing when editing post

[garyc40]

Problem #1 : Reply to comment

Steps to reproduce:

1. Edit a post that has some comments
2. Click "Reply" on a comment

-> The comment form's width is only about a half of that of the comment list

3. Type the reply and hit "Submit Reply"

-> All the comments' width became about half of the meta box. Only the new comment is displayed correctly

Problem #2 : Approving comment

Steps to reproduce:

Try approving an unapproved comment when editing a post.

-> The row's background color changed, and the "Approve" link changed to "Unapprove", but only for a slight moment. Then it switched back to look like it's still unapproved.

Same thing happen when you unapprove a previously approved comment.

Problem #3: Trashing a comment

Trash a comment. The "moved to the trash" message appears, but the commenter's gravatar appears twice.

Also, it's not a comment river (trashing or spamming comments doesn't seem to refill the list)

Confirmed - this is completely borked. Additional minor issue of missing padding is also present - ​http://cl.ly/3gnO

All three are regressions (not sure about the comment river note though). Also, in 3.0.3 we didn't show the gravatar and there was also a heading row with titles Author and Comment above the comments.

With some quick investigation firebug is showing me that the wpList.ajaxDim function is being triggered twice and so two AJAX requests are being made, could possibly be the cause to the second two problems here?

there's a patch for that

The patch fixed 3 problems listed above, however I discovered 2 more problems:

1. Duplicate comment error message

Try replying to a comment with a test message. Then replying to any comment with the same message. There should be an error message: "Duplicate comment detected; it looks as though you’ve already said that!". However, it doesn't look like it's styled correctly (see screenshot).

2. If I have more than 10 comments, and click "Show more comments", the exact same 10 comments that have already been listed appear.

I'm working on a fix for both.

Patch introduced a bug: comment list table's column headers are visible. Fixing.

fixed css styling & "show more comments" behavior

how it looks BEFORE the patch is applied

how it looks AFTER the patch is applied

I modified the css a bit so that the "Comments" meta box looks consistent with "Recent comments" on the Dashboard, as well as with the Comments edit page.

Needs UI feedback.

removed "console.log"

I notice the rev3 patch doing some changes in WP_Post_Comments_List_Table::get_column_info and WP_Post_Comments_List_Table::print_column_headers, but I still don't see the column headers in the screenshot.

I added the headers but I hide the span inside <th>. This is a trick to set column width while the headers are being hidden (otherwise the widths will be 50% 50%). Don't know if there's any cleaner trick though.

Replying to garyc40:

I added the headers but I hide the span inside <th>. This is a trick to set column width while the headers are being hidden (otherwise the widths will be 50% 50%). Don't know if there's any cleaner trick though.

I meant that the column headers actually showed up in 3.0.3 (​link to the screenshot you posted in IRC).

Before I patched this, the column headers were already hidden (or rather, not being output at all), see http://core.trac.wordpress.org/attachment/ticket/15876/before.png .

So should it display the header? Recent Comments on Dashboard doesn't have the headers though.

patch that solves all of the problems, with original style from 3.0.3

Added another patch, basically does the same thing as rev3. However, the style of the comment meta box is the same as in 3.0.3 (no gravatar, column headers visible).

How it looks in 3.0.3: ​http://awesomescreenshot.com/0894v1t2c

added back original author column width, and removed duplicate error styles

So which are the two final patches we should look at?

Two final patches:

New style: garyc40-15876-rev3.patch

Original style: garyc40-15876-original-style-revised.patch

Sorry for the confusion.

Both patches seem to work fine.

I obviously like the new style more.

The new styling is fine, CSS isn't the issue.

But I see a lot of code changes here. We need to be careful.

If you don't show the column headers at all, why do you overwrite print_column_headers() in WP_Post_Comments_List_Table?

It's because without column headers (<th> elements specifically), I can't find any way to adjust the width of the columns. Applying width:30% for example to the td.column-xxx didn't work. Even if I output the headers, then display:none, widths are not adjusted as well. They just automatically reset to 50% / 50%. That's why I have to introduce <span> inside <th> .

Anyone knows if there's a way to adjust columns' width without <th>? let me know and I'll update the patch :)

Another way is to use <colgroup>, but we have to print it before <thead>.

removed table headers completely as per scribu's suggestion

Latest patch removed table headers completely by overriding WP_List_Table::display(). Obviously a cleaner solution than the previous patch.

no array_push()

$wp_list_table->checkbox = ( isset($_POST['checkbox']) && true == $_POST['checkbox'] ) ? 1 : 0; 
$wp_list_table = get_list_table('WP_Comments_List_Table');

Should be reversed, no?

set checkbox property after get_list_table()

Do we need to enumerate the list table class there - I thought the class name was in the ajax request anyway?

set checkbox property after get_list_table()

Actually, I don't think we need the checkbox property at all. That is a relic from before WP_Post_Comments_List_Table.

Replying to westi:

Do we need to enumerate the list table class there - I thought the class name was in the ajax request anyway?

I didn't see any class name in the ajax request. I just basically ported the table in post_comment_meta_box() into WP_Post_Comments_List_Table::display(), and keep the classes and id intact, in case it might break some javascript.

Replying to scribu:

Actually, I don't think we need the checkbox property at all. That is a relic from before WP_Post_Comments_List_Table.

Sure, I'll remove it in the final patch after the current patch has been scrutinized.

Replying to garyc40:

Replying to westi:

Do we need to enumerate the list table class there - I thought the class name was in the ajax request anyway?

I didn't see any class name in the ajax request. I just basically ported the table in post_comment_meta_box() into WP_Post_Comments_List_Table::display(), and keep the classes and id intact, in case it might break some javascript.

I guess we aren't using the generic list table js then here.

removed $wp_list_table->checkbox

Per IRC bug scrub today, this should be commited, but it seems nobody got around to it yet.

(In [17113]) Fix comment manipulation on edit post screen. Props garyc40. fixes #15876

When replying to comments, the Reply form is still wrapped in one column (colspan = 0) instead of 2.

fixed colspan problem with reply form

Replying to garyc40:

When replying to comments, the Reply form is still wrapped in one column (colspan = 0) instead of 2.

Can't reproduce the problem. Tried on the dashboard box, the post metabox and the list table, with Firefox and Chrome.

Post comment meta box, replying to a comment, Chrome

Screenshot attached.

Nothing went wrong with dashboard box or the comment list table, only the post metabox.

The main reason is because the table headers are removed, so when the reply form is opened, line 341 in edit-comments.dev.js sets colspan to 0.

Was able to reproduce eventually. Patch is good to go.

(In [17124]) Fix comment reply colspan. Props garyc40. fixes #15876