Opened 2 years ago

Closed 2 years ago

#15913 closed defect (bug) (fixed)

submit button with the id of 'save' is too wide

Reported by: nacin Owned by: markjaquith
Priority: normal Milestone: 3.1
Component: UI Version:
Severity: normal Keywords: has-patch
Cc:

Description

Coming out of #15064, we're adding id="save" to a number of submit buttons that didn't have it previously, as name had equaled "save".

Overly generic CSS somewhere gives this submit button a width of 15em. This is prevalent on upload.php, comment.php?action=edit and possibly elsewhere.

Kill the CSS rule, make it more specific for its intended save button.

Attachments (1)

15913.diff​ (407 bytes) - added by scribu 2 years ago.

Download all attachments as: .zip

Change History (5)

scribu — 2 years ago

comment:1   scribu — 2 years ago

  • Keywords has-patch added

comment:2   nacin — 2 years ago

Is the rule even necessary then?

comment:3   markjaquith — 2 years ago

  • Owner set to markjaquith
  • Status changed from new to accepted

Don't think it is. And with the patch, the media editing screen's button is bigger than it was in 3.0. In any case, less is broken by a button that is too small than buttons that are too big. Removing the rule.

comment:4   markjaquith — 2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [17104]) Remove overly broad CSS rule. fixes #15913

Note: See TracTickets for help on using tickets.