Opened 2 years ago
Closed 5 weeks ago
#15948 closed defect (bug) (fixed)
dbDelta SET Default <literal> Comment <literal>
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | Database | Version: | 3.1 |
| Severity: | major | Keywords: | has-patch 3.2-early |
| Cc: |
Description (last modified by scribu)
When dbDelta from wp_admin/includes/upgrade.php is used with a query containing different DEFAULT values than the actual TABLE in the database, dbDelta tries to update this DEFAULT value by altering the table. The regex that is used to find the new DEFAULT value is incorrect.
Right now, the regex is:
| DEFAULT '(.*)'|i
but this should be:
| DEFAULT '([^']*)'|i
...since, in the case a COMMENT value is set in the new query, the COMMENT value is also surrounded by single quotes ' COMMENT 'literal is added to the new default value.
Attachments (1)
Change History (8)
- Keywords has-patch 3.2-early added; sql regex removed
- Milestone changed from Awaiting Review to Future Release
Seems sane enough to me, We should ensure that it matches the command as best as possible.
wonderboymusic — 4 months ago
comment:4
wonderboymusic — 4 months ago
- Milestone changed from Future Release to 3.6
this appears harmless to me
comment:5
SergeyBiryukov — 4 months ago
- Component changed from Upgrade/Install to Database
I'm changing this to non-greedy (.*?) as it is more obvious (to me) what is going on.
Note: See
TracTickets for help on using
tickets.
The regex should be | DEFAULT '([^']*)'|i
I didn't know about the WikiFormatting of ^.