Opened 2 years ago

Last modified 13 months ago

#15956 new defect (bug)

Remove user link should be red

Reported by: scribu Owned by:
Priority: normal Milestone: Future Release
Component: Multisite Version:
Severity: normal Keywords: has-patch
Cc:

Description (last modified by scribu)

On MultiSite, a user has a 'Delete' action link, which erases them from the system completely. It is red.

When going to Network Admin -> Sites -> Edit Site -> Users there is a 'Remove' link, which only erases a user from a certain site in the network. This is currently blue.

Since it's still a destructive action (no trash), the 'Remove' link should be red as well.

Attachments (1)

15956.diff (1.3 KB) - added by greuben 2 years ago.

Download all attachments as: .zip

Change History (8)

  • Description modified (diff)

greuben2 years ago

  • Keywords has-patch added
  • Component changed from UI to Multisite
  • Description modified (diff)
  • Milestone changed from Future Release to 3.4

Patsh still works.

comment:4 follow-up: ↓ 5   scribu15 months ago

  • Keywords ux-feedback added

Now I'm starting to wonder if this was intentional. It's a destructive operation, but it doesn't remove the user.

Version 0, edited 15 months ago by scribu (next)

comment:5 in reply to: ↑ 4   DrewAPicture15 months ago

Replying to scribu:

It's a destructive operation, but it doesn't delete the user.

From a consistency standpoint, it should only be red if it completely deletes something just as in Menus we have Delete Menu. You're removing access for a user but not deleting the account and that's why it shouldn't be red. My 2¢.

  • Keywords ux-feedback removed

Link colors are not consistent in general. Widgets have blue Delete links that turn red on hover, as do Close links (terrible!). We should do a link colors inventory for 3.5 and make them all comply with styleguide. Remove|Cancel in menus doesn't really make sense either. We're overdue for a consistency sweep on button and link text.

  • Milestone changed from 3.4 to Future Release
Note: See TracTickets for help on using tickets.